Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-230: Quick: Ensure search bar font sizes match #231

Merged

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented May 25, 2021

Goal

Ensure font size of search bar elements match across Docs, CMS, and Portal.

Notice: The search bar will be redesigned in GH-101. If it is not already redesigned in branch task/GH-101-header-redesign, then its font size there is fixed and consistent (but smaller).

Related

Changes

¹ These were fixing this problem before Frontera migrated to Camino deploy process. But they have no effect on Portal because of bug #223 (which arose after Frontera migration).

Testing

Frontera CMS

Via Test CMS Changes (wiki), test using either option:

  • load taccwma/frontera-cms:2e4a2d7 (from Jenkins Core_CMS build #97)
  • load this branch and change .env to CUSTOM_ASSET_DIR=frontera-cms

Then:

  1. Open Docs, Portal, CMS.
  2. Ensure font sizes of header search button and search field match.

Alternatively, add—to a Frontera CMS—the relevant snippet from dev.cep which temporarily fixes / basically tests this.

Core CMS

Via Test CMS Changes (wiki), test using either option:

Then:

  1. Open Docs, Portal, CMS.
  2. Ensure font sizes of header search button and search field match.

Alternatively, dev.cep has a snippet that can be added to "Footer-Content" to temporarily fix / basically test this issue.

- Set font size manually, like GH-101 does.
- Remove Frotnera-specific font sizes, like GH-101 does.
Copy link
Member

@rstijerina rstijerina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

@wesleyboar wesleyboar merged commit 828a5dd into main Jun 15, 2021
@wesleyboar wesleyboar deleted the bugfix/GH-230-header-search-bar-font-size-inconsistent branch June 15, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header Search Bar Font Size Differs Among Subsites
3 participants