Hotfix: GH-157 Frontera Redesign Use Global Color Vars #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar
changed the title
wesleyboar
commented
Apr 27, 2021
Comment on lines
+13
to
+15
| /* NOTE: Portal does not need this, because it has independent copy of these, | ||
| but the User Guides do not. This can be removed in Core-CMS PR #192 */ | ||
| @import url("../../../site_shared/css/src/_imports/settings/color.css"); |
There was a problem hiding this comment.
Portal and CMS both having independent copies of global color variables is a problem I'll solve later this year.
rstijerina
approved these changes
Apr 28, 2021
wesleyboar
deleted the
hotfix/GH-157-frontera-redesign--GH-181-use-global-color-vars
branch
wesleyboar
changed the title
wesleyboar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix gray text in header on Frontera User Guide.
I.e. fix bug introduced by #181.
Changes
Testing
Screenshots
Before
Pre-Prod (Before)
Pre-Prod Frontera Docs sans Fix
Pre-Prod Frontera Portal sans Fix
Pre-Prod Frontera CMS sans Fix
Local (Before)
Local Frontera Docs sans Fix
Local Frontera Portal sans Fix
Local Frontera CMS sans Fix
After
Dev (After)
Dev Frontera Docs with Fix
Dev Frontera Portal with Fix
Dev Frontera CMS with Fix
Local (After)
Local Frontera Docs with Fix
Local Frontera Portal with Fix
Local Frontera CMS with Fix
Notes
The search bar is bigger on Portal than in CMS and User Guide. This is true on production, pre-prod, dev, and local. It will be fixed separately from this hotfix.