Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/gh 157 frontera redesign 0 #187

Merged
merged 19 commits into from
Apr 16, 2021
Merged

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Apr 10, 2021

To Do

Overview

Propagate most of Frontera Homepage Redesign to Core.

Issues

Changes

Testing

  1. Ensure that proper deploy on Dev matches snippet-based version on Prod.

Note: Some aspects were also tested in isolation via the various PRs made to this branch. Furthermore, I also reviewed each set of related changes in those PRs and this PR to the original bulk PR—identical.

Screenshots

Latest

These images should appear identical.

Dev Server - Using Latest Code & Content 😍
Render Temporary Snippets Updated Snippets
Using Latest Code   Content System Monitor
Prod Server - Using Snippets for Styles 😱
Render Temporary Snippets Updated Snippets
Prod Using Snippets for Styles Prod Snippets for Frontera Redesign System Monitor

Archive

These images represent status while pending deploy on dev.

Dev Server - Prod Content Awaiting Code 😭
Render Temporary Snippets Updated Snippets
Dev Awaiting Deploy of Styles   Template System Monitor
Local Server - Using Placeholder Content 🥸
Render Temporary Snippets Updated Snippets
Local Using Placeholder Content System Monitor

wesleyboar and others added 16 commits April 9, 2021 18:23
1. Update import because of a file move (see change 4a).
2. Add import and export stylesheet for loading font faces.
3. Load all Benton Sans font faces (that Frontera Redesign uses).
4. Move settings, change one value, cleanup file
4A. Move font.css settings from site_shared to site_cms.*
4B. Change global font family.
4C. Cleanup font settings.
4Ci. Update comments.
4Cii. Comment out unused settings.
4Ciii. Add font weight settings (and shorthand)

* I am silently, gradually deprecating `site_shared`.
…ader-footer

GH-157: Header & Footer: Update Colors. Use Vars
…dy-element-tweaks

GH-157: Body Tag: Explicit Line Height & Min-Width
…sure-search-field-font-matches-portal

GH-157: Search Bar: Match Portal Font (Roboto)
…dia-queries-max-widths

GH-157: Standardize Media Queries & Max Widths
…-180-change-standard-font

GH-157: Change Standard Font (+ Some Polish)
…w-stylesheets

GH-157: Add New Stylesheets for Frontera Redesign
Article list can be section or within one; selectors neglected former.
@wesleyboar wesleyboar requested a review from taoteg April 12, 2021 14:57
@wesleyboar wesleyboar linked an issue Apr 12, 2021 that may be closed by this pull request
4 tasks
Copy link
Collaborator

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work. =)

@wesleyboar wesleyboar merged commit e3c4a55 into main Apr 16, 2021
@wesleyboar wesleyboar deleted the task/GH-157-frontera-redesign-0 branch April 22, 2021 15:07
@wesleyboar wesleyboar linked an issue Jun 30, 2021 that may be closed by this pull request
@wesleyboar wesleyboar mentioned this pull request Jun 30, 2021
@wesleyboar wesleyboar linked an issue Jun 30, 2021 that may be closed by this pull request
@wesleyboar wesleyboar added this to the Frontera Redesign Phase 0 milestone Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants