-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/gh 157 frontera redesign 0 #187
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Update import because of a file move (see change 4a). 2. Add import and export stylesheet for loading font faces. 3. Load all Benton Sans font faces (that Frontera Redesign uses). 4. Move settings, change one value, cleanup file 4A. Move font.css settings from site_shared to site_cms.* 4B. Change global font family. 4C. Cleanup font settings. 4Ci. Update comments. 4Cii. Comment out unused settings. 4Ciii. Add font weight settings (and shorthand) * I am silently, gradually deprecating `site_shared`.
…ader-footer GH-157: Header & Footer: Update Colors. Use Vars
…dy-element-tweaks GH-157: Body Tag: Explicit Line Height & Min-Width
…sure-search-field-font-matches-portal GH-157: Search Bar: Match Portal Font (Roboto)
…dia-queries-max-widths GH-157: Standardize Media Queries & Max Widths
…era-redesign-0--GH-180-change-standard-font
…-180-change-standard-font GH-157: Change Standard Font (+ Some Polish)
…w-stylesheets GH-157: Add New Stylesheets for Frontera Redesign
…e-CMS into task/GH-157-frontera-redesign-0
Article list can be section or within one; selectors neglected former.
This was referenced Apr 12, 2021
Closed
Closed
4 tasks
taoteg
approved these changes
Apr 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work. =)
This was
linked to
issues
Apr 16, 2021
Closed
Closed
This was referenced Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Do
Overview
Propagate most of Frontera Homepage Redesign to Core.
Issues
Changes
Testing
Screenshots
Latest
These images should appear identical.
Dev Server - Using Latest Code & Content 😍
Prod Server - Using Snippets for Styles 😱
Archive
These images represent status while pending deploy on dev.
Dev Server - Prod Content Awaiting Code 😭
Local Server - Using Placeholder Content 🥸