Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offset Content Plugin #66

Closed
wesleyboar opened this issue Jan 28, 2021 · 3 comments · Fixed by #257
Closed

Offset Content Plugin #66

wesleyboar opened this issue Jan 28, 2021 · 3 comments · Fixed by #257
Labels
effort S Small effort task (~½ a week) — does not include review time feature A new feature or replacement of present feature priority ▼ Low priority

Comments

@wesleyboar
Copy link
Member

wesleyboar commented Jan 28, 2021 •
edited
Loading

Goal

Background

On Texascale, in articles, blockquotes and figures were offset (on wide screens) from the layout of surrounding text. A tentative name, "offset content" was given to the class used to support this aesthetic. After a discussion about official CMS components, Hedda clarified that this component should only allow other components within it—this distinguishes it from content floated via a WYSIWYG. So, I have renamed the component from "offset content" to "offset component" to better reflect that this component is a "component wrapper" (in ITCSS-speak, this is an "object", not a component).

Direction
@wesleyboar wesleyboar changed the title Offset Content Component Offset Content Plugin Jan 29, 2021
@wesleyboar wesleyboar added feature A new feature or replacement of present feature effort S Small effort task (~½ a week) — does not include review time priority ▼ Low priority labels Jan 29, 2021
This was referenced Jun 17, 2021
Merged
Merged
Closed
@wesleyboar
Copy link
Member Author

Finished basic creation in #257. Created #260 to improve this plugin.

@wesleyboar wesleyboar linked a pull request Jul 6, 2021 that will close this issue
GH-73: Blockquote Plugin & GH-66: Offset Content Plugin #257
Merged
1 task
@wesleyboar wesleyboar mentioned this issue Jul 9, 2021
Merged
1 task
@wesleyboar wesleyboar linked a pull request Jul 12, 2021 that will close this issue
dev → main (GH-73, GH-66 & FP-1099 & GH-93, GH-142, GH-133) #259
Closed
@wesleyboar wesleyboar mentioned this issue Jul 12, 2021
Merged
1 task
wesleyboar added a commit that referenced this issue Jul 12, 2021
@wesleyboar
Revert #265 then #261 (other plugins) to (almost) isolate GH-93 changes
dc6816b 
NOTE: To revert #257 (GH-73, GH-66) is more difficult, so it is not reverted in this commit.

Revert "Merge pull request #265 from TACC/quick/clean-up-plugins-to-match-GH-93-plugins"

This reverts commit 2caa727, reversing
changes made to b76fda0.

Revert "Quick: Improve import caveat comments"

This reverts commit 66380a2.
wesleyboar added a commit that referenced this issue Jul 13, 2021
@wesleyboar
Revert #257 (GH-73 & GH-66)
face1ac 
Revert "Merge pull request #257 from TACC/task/GH-73-tacc-blockquote-plugin"

This reverts commit 0a82cd7, reversing
changes made to f48ecd2.
wesleyboar added a commit that referenced this issue Jul 13, 2021
@wesleyboar
Revert #265 then #261 (other plugins) to (almost) isolate GH-93 changes
891e578 
NOTE: To revert #257 (GH-73, GH-66) is more difficult, so it is not reverted in this commit.

Revert "Merge pull request #265 from TACC/quick/clean-up-plugins-to-match-GH-93-plugins"

This reverts commit 2caa727, reversing
changes made to b76fda0.

Revert "Quick: Improve import caveat comments"

This reverts commit 66380a2.
wesleyboar added a commit that referenced this issue Jul 13, 2021
@wesleyboar
Revert #257 (GH-73 & GH-66)
a196076 
Revert "Merge pull request #257 from TACC/task/GH-73-tacc-blockquote-plugin"

This reverts commit 0a82cd7, reversing
changes made to f48ecd2.
@wesleyboar
Copy link
Member Author

Issue should not be closed, because:

  • PR is not merged.
  • Code is not deployed on prod.

@wesleyboar wesleyboar reopened this Aug 31, 2021
@wesleyboar
Copy link
Member Author

Merged to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort S Small effort task (~½ a week) — does not include review time feature A new feature or replacement of present feature priority ▼ Low priority
Projects
None yet
Milestone
No milestone
1 participant
@wesleyboar