Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wheel top-level status cookie and mark armv5 as unsupported >= python 3.12 #6428

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented Jan 26, 2025

Description

Add wheel top-level status cookie and mark armv5 as unsupported >= python 3.12

Relates to comments:

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

@th0ma7 th0ma7 requested a review from hgy59 January 26, 2025 23:23
@th0ma7 th0ma7 self-assigned this Jan 26, 2025
@th0ma7
Copy link
Contributor Author

th0ma7 commented Jan 26, 2025

@hgy59 I believe this would be addressing your two concerns. Would you mind giving it a shot? thnx.

@th0ma7 th0ma7 mentioned this pull request Jan 27, 2025
5 tasks
@th0ma7 th0ma7 merged commit eaccddc into SynoCommunity:master Jan 29, 2025
1 check passed
@th0ma7 th0ma7 deleted the wheel-fix2 branch January 29, 2025 00:51
@mreid-tt
Copy link
Contributor

@th0ma7, with the mk/spksrc.python.mk now including mk/spksrc.common.mk, I am guessing that we shouldn't have Makefiles with both anymore?

For example in my current #6431: spk/sabnzbd/Makefile

@th0ma7
Copy link
Contributor Author

th0ma7 commented Jan 30, 2025

Yes and no... It's a question of timing as if you require a call to version_* for instance you'll need to source common.mk prior to it, or calling it after python.mk

@mreid-tt
Copy link
Contributor

Okay, I just moved the include call earlier in the file and it seems to be okay. Here's the updated spk/sabnzbd/Makefile.

@th0ma7
Copy link
Contributor Author

th0ma7 commented Jan 30, 2025

Rule of thumbs include of python.mk similarly to cross-cc.mk or spk.mk should always go at the end.

Only locally declared recipes would go after.

You could place call to version* after it as well if it's a one liner but i suggest calling common.mk right before instead.

Most important, all *TARGET déclarations must go above it as otherwise it becomes a redeclaration of an already existing recipe.

Exemple :

POST_INSTALL_TARGET = bla

include spksrc.python.mk

.PHONY: bla
bla:
     Myrecipe abcd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants