-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wheel building: Pile of small fixes to recent changes #6409
Conversation
The build of pendulum as python wheel succeeded locally for armv7-7.1 and aarch64-7.1 so far. |
@mreid-tt and @hgy59 FYI I have found a false positive whereas compilation would continue although errors may have been trigerred. This is due to Currently working on figuring out exactly a) how to ensure it does halt on errors and b) where the errors are. At first glance it looks relatively easy to solve and limited in scope. I'll keep you posted once solved (fix to be in this PR). |
I may have now solved the issue where wheel builds should halt properly on errors. This brought light to other wheel build issues such as with Remaining there may still be a weird case involving |
@hgy59 This PR is now ready for review. Many small changes and fixed many small'ish long-standing issues. Been testing it for a few days and cannot find anything left. |
pending: |
I'm guessing that based on the cadence of Python development it would be prudent to go to 3.13. I agree with you that the finalisation of |
There's also a need to be strategic with regards to impacts... python311:
python312:
python313:
Migration directly to |
- add cross/pendulum with patch for 32-bit archs - add cross/pendulum to python311-wheels
bec5717
to
f92a493
Compare
we have some python-wheel packages with (empty) PLIST file and some without PLIST. we can cleanup this in another PR:
|
Co-authored-by: hgy59 <hpgy59@gmail.com>
@th0ma7 still an issue with wheel status cookies. When I run make on a package after a successful build, or after successful build and running It should only create the INFO file, the scripts, wizard, ... (files outside package.tgz) and finally update the spk package. Otherwise it takes too long and overwhelms with logs, when working on the service-setup or on the wizard files for packages that successfully build so far.... Remarks: |
indeed, i had that previously but it was a pain to play with when wanting to redo/debug/test some other wheels. But that is dam easy to bring back, further what your suggesting is changing the wheel level so it can be cleaned-up at It doesn't avoid python migration to occur though, and I'll submit a PR for that in no time, easy to tackle. |
Description
Fixes:
python-wheel.mk
fix for maturin built based wheelscrossenv
callsPATH
definitions and call tocross-python3
python311
python312
andpython312-wheels
python313
and createpython313-wheels
crossenv
msgpack==1.0.5
or it fails to install the crossenv.spksrc.python-wheel.mk
pillow
versionsFollows-up:
Checklist
all-supported
completed successfullyType of change