remove use of PYTHON_FOUND #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variable no longer exists when using find(Python ...), i.e. with CMake 3.12 or more recent. Fixes SyneRBI#939
|
I am not sure anymore why we only see this. Locally I'm running with CMake 3.17 anyway. Possibly CMake was still setting anyway, I think this PR will fix it. |
ALEXJAZZ008008
approved these changes
Jun 4, 2021
|
great. what is your CMake version actually? |
|
I'm using CMake 3.10.2, it's the most recent version in the Ubuntu 18.04 repository. |
[ci skip]
it completely baffles me, but anyway... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This variable no longer exists when using
find(Python ...), i.e. with CMake 3.12 or more recent.Fixes #939