Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python libraries not built #939

Closed
KrisThielemans opened this issue Jun 4, 2021 · 1 comment · Fixed by #941
Closed

Python libraries not built #939

KrisThielemans opened this issue Jun 4, 2021 · 1 comment · Fixed by #941
Assignees
@KrisThielemans
Labels
bug
Milestone
v3.1

Comments

@KrisThielemans
Copy link
Member

@ALEXJAZZ008008 has a case where Python is found as the (SuperBuild) log says

-- Python libraries found
-- SIRF Python modules will be installed in /home/alex/Documents/new_SIRF-SuperBuild/SIRF-SuperBuild_build/INSTALL/python

but pSTIR etc are not built.

I believe this is due to

SIRF/src/xSTIR/CMakeLists.txt

Line 20 in 7846174

if (PYTHON_FOUND AND BUILD_PYTHON)

as we now use

SIRF/CMakeLists.txt

Line 124 in 7846174

find_package(Python COMPONENTS Interpreter Development)

the variable is called Python_FOUND.

PR coming.
@KrisThielemans KrisThielemans added this to the v3.1 milestone Jun 4, 2021
@KrisThielemans KrisThielemans self-assigned this Jun 4, 2021
KrisThielemans added a commit to KrisThielemans/SIRF that referenced this issue Jun 4, 2021
@KrisThielemans
remove use of PYTHON_FOUND
6bd0874 
This variable no longer exists when using find(Python ...),
i.e. with CMake 3.12 or more recent.

Fixes SyneRBI#939
@KrisThielemans KrisThielemans mentioned this issue Jun 4, 2021
Merged
KrisThielemans added a commit that referenced this issue Jun 4, 2021
@KrisThielemans
remove use of PYTHON_FOUND (#941)
7822bdd 
This variable no longer exists when using find(Python ...), i.e. with CMake 3.12 or more recent, and was causing some problems. As we don't need it, this removes its usage.

Fixes #939
@KrisThielemans KrisThielemans changed the title Python libraries not built with recent CMake Python libraries not built Jun 4, 2021
@KrisThielemans
Copy link
Member Author

This was with CMake 3.10.2, but not for @AnderBiguri with the same CMake. Oh well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KrisThielemans KrisThielemans

Labels
bug
Projects
None yet
Milestone
v3.1
Development

Successfully merging a pull request may close this issue.

remove use of PYTHON_FOUND KrisThielemans/SIRF
1 participant
@KrisThielemans