Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proj_EXTRA_CMAKE_ARGS facility is broken for most projects #616

Closed
KrisThielemans opened this issue Aug 20, 2021 · 1 comment · Fixed by #617
Closed

proj_EXTRA_CMAKE_ARGS facility is broken for most projects #616

KrisThielemans opened this issue Aug 20, 2021 · 1 comment · Fixed by #617
Assignees
@KrisThielemans
Labels
bug
Milestone
v3.2

Comments

@KrisThielemans
Copy link
Member

3ef3504 removed ${proj}_EXTRA_CMAKE_ARGS_LIST but most External*cmake files are still using it. Therefore, setting ${proj}_EXTRA_CMAKE_ARGS is ignored for all projects except ITK
@KrisThielemans KrisThielemans added this to the v3.2 milestone Aug 20, 2021
@KrisThielemans KrisThielemans self-assigned this Aug 20, 2021
KrisThielemans added a commit to KrisThielemans/SIRF-SuperBuild that referenced this issue Aug 20, 2021
@KrisThielemans
fix obsolete usage of ${proj}_EXTRA_CMAKE_ARGS_LIST
027e1b1 
The user is instructed to set ${proj}_EXTRA_CMAKE_ARGS. We forgot
to remove usage of ${proj}_EXTRA_CMAKE_ARGS_LIST for all projects
except ITK.

Fixes SyneRBI#616
@KrisThielemans
Copy link
Member Author

@AnderBiguri not sure if this affects any of your build scripts...

@KrisThielemans KrisThielemans mentioned this issue Aug 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KrisThielemans KrisThielemans

Labels
bug
Projects
None yet
Milestone
v3.2
Development

Successfully merging a pull request may close this issue.

fix obsolete usage of ${proj}_EXTRA_CMAKE_ARGS_LIST KrisThielemans/SIRF-SuperBuild
1 participant
@KrisThielemans