Skip to content

Commit

Permalink
fix obsolete usage of ${proj}_EXTRA_CMAKE_ARGS_LIST
Browse files Browse the repository at this point in the history
The user is instructed to set ${proj}_EXTRA_CMAKE_ARGS. We forgot
to remove usage of ${proj}_EXTRA_CMAKE_ARGS_LIST for all projects
except ITK.

Fixes SyneRBI#616
  • Loading branch information
KrisThielemans committed Aug 20, 2021
1 parent da27720 commit 027e1b1
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 9 deletions.
3 changes: 1 addition & 2 deletions CMake/SetExternalProjectFlags.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@

macro(SetExternalProjectFlags proj)

set(${proj}_EXTRA_CMAKE_ARGS "" CACHE STRING "Optional extra CMake arguments to be appended to the flags set by the SuperBuild(use semi-colons for multiple arguments)")
set(${proj}_EXTRA_CMAKE_ARGS "" CACHE STRING "Optional extra CMake arguments to be appended to the flags set by the SuperBuild (use semi-colons for multiple arguments)")
mark_as_advanced(${proj}_EXTRA_CMAKE_ARGS)
# string(REPLACE " " ";" ${proj}_EXTRA_CMAKE_ARGS_LIST "${${proj}_EXTRA_CMAKE_ARGS}")
message(STATUS ${proj}_EXTRA_CMAKE_ARGS= "${${proj}_EXTRA_CMAKE_ARGS}")
endmacro()
2 changes: 1 addition & 1 deletion SuperBuild/External_JSON.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ if(NOT ( DEFINED "USE_SYSTEM_${externalProjName}" AND "${USE_SYSTEM_${externalPr
${${proj}_EP_ARGS_DIRS}
CMAKE_ARGS
-DJSON_BuildTests:BOOL=${BUILD_TESTING_${proj}}
${${proj}_EXTRA_CMAKE_ARGS_LIST}
${${proj}_EXTRA_CMAKE_ARGS}
DEPENDS ${${proj}_DEPENDENCIES}
)

Expand Down
2 changes: 1 addition & 1 deletion SuperBuild/External_NIFTYREG.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ if(NOT ( DEFINED "USE_SYSTEM_${externalProjName}" AND "${USE_SYSTEM_${externalPr
-DUSE_OPENMP:BOOL=${${proj}_ENABLE_OPENMP}
-DBUILD_ALL_DEP:BOOL=ON
-DUSE_CUDA:BOOL=${${proj}_USE_CUDA}
${${proj}_EXTRA_CMAKE_ARGS_LIST}
${${proj}_EXTRA_CMAKE_ARGS}
DEPENDS ${${proj}_DEPENDENCIES})

set(${proj}_ROOT ${${proj}_SOURCE_DIR})
Expand Down
2 changes: 1 addition & 1 deletion SuperBuild/External_NiftyPET.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ if(NOT ( DEFINED "USE_SYSTEM_${externalProjName}" AND "${USE_SYSTEM_${externalPr
-DPYTHON_EXECUTABLE=${NiftyPET_PYTHON_EXECUTABLE}
-DPYTHON_INCLUDE_DIR:PATH=${NiftyPET_PYTHON_INCLUDE_DIR}
-DPYTHON_LIBRARY=${NiftyPET_PYTHON_LIBRARY}
${${proj}_EXTRA_CMAKE_ARGS_LIST}
${${proj}_EXTRA_CMAKE_ARGS}
DEPENDS
${${proj}_DEPENDENCIES}

Expand Down
2 changes: 1 addition & 1 deletion SuperBuild/External_SIRF.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ if(NOT ( DEFINED "USE_SYSTEM_${externalProjName}" AND "${USE_SYSTEM_${externalPr
-DOPENMP_LIBRARIES:PATH=${OPENMP_LIBRARIES}
${extra_args}
-DGadgetron_USE_CUDA=${Gadgetron_USE_CUDA}
${${proj}_EXTRA_CMAKE_ARGS_LIST}
${${proj}_EXTRA_CMAKE_ARGS}
DEPENDS
${${proj}_DEPENDENCIES}
)
Expand Down
2 changes: 1 addition & 1 deletion SuperBuild/External_STIR.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ if(NOT ( DEFINED "USE_SYSTEM_${externalProjName}" AND "${USE_SYSTEM_${externalPr
${STIR_CMAKE_ARGS}
${Boost_CMAKE_ARGS}
${HDF5_CMAKE_ARGS}
${${proj}_EXTRA_CMAKE_ARGS_LIST}
${${proj}_EXTRA_CMAKE_ARGS}
DEPENDS
${${proj}_DEPENDENCIES}
)
Expand Down
2 changes: 1 addition & 1 deletion SuperBuild/External_TomoPhantom.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ if(NOT ( DEFINED "USE_SYSTEM_${externalProjName}" AND "${USE_SYSTEM_${externalPr
${PYTHONLIBS_CMAKE_ARGS}
-DPYTHON_DEST_DIR:PATH=${PYTHON_DEST_DIR}
-DPYTHON_STRATEGY=${PYTHON_STRATEGY}
${${proj}_EXTRA_CMAKE_ARGS_LIST}
${${proj}_EXTRA_CMAKE_ARGS}
# TODO this relies on using "make", but we could be build with something else
#INSTALL_COMMAND make TomoPhantom
DEPENDS
Expand Down
2 changes: 1 addition & 1 deletion SuperBuild/External_parallelproj.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ if(NOT ( DEFINED "USE_SYSTEM_${externalProjName}" AND "${USE_SYSTEM_${externalPr
${${proj}_EP_ARGS_DIRS}

CMAKE_ARGS ${${proj}_CMAKE_ARGS}
${${proj}_EXTRA_CMAKE_ARGS_LIST}
${${proj}_EXTRA_CMAKE_ARGS}
DEPENDS
${${proj}_DEPENDENCIES}
)
Expand Down

0 comments on commit 027e1b1

Please sign in to comment.