Added Dutch translations (in intl-icu format) #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @evertharmeling! Unless there is some problem with mixing the translation formats that i'm not aware of, I'm ok with having either :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Dutch translations. Because of the somewhat complex nature of the Dutch language (0 vs 1 vs many) I've chosen to use the
intl-icuformat as it (suppose to be/) is the new standard and has better support for the complex scenarios. And as the minimum requirements of the bundle aresymfony/*:^4.4it should not be a problem. Also Christophe mentioned to it in #56 (comment).If we would refactor all translations in one go to the
icu-intlformat and first use the old notation, let me know I would adjust this PR.As for the Dutchies who want to check this PR, I've used the 'rules' in https://taaladvies.net/taal/advies/vraag/511 to translate it (used in \SymfonyCasts\Bundle\VerifyEmail\Model\VerifyEmailSignatureComponents::getExpirationMessageKey()), see: