add Polish translations #56
Conversation
| <body> | ||
| <trans-unit id="1"> | ||
| <source>%count% year|%count% years</source> | ||
| <target>%count% roku|%count% lat</target> |
There was a problem hiding this comment.
I'm not sure is it correct translation. Can you write some sentence with this translation to understand your intention?
There was a problem hiding this comment.
This link will expire in 1 year || This link will expire in 3 years
I'm not fluent in Polish, so please feel free to correct this if it's wrong. Thanks @mwadon
There was a problem hiding this comment.
Yes! In English, it would look like this:
This link will expire in {{ resetToken.expirationMessageKey|trans(resetToken.expirationMessageData, 'ResetPasswordBundle') }}.
Where the {{ }} part will be the translation - for example "1 year" or "3 years"` in English.
Thanks!
There was a problem hiding this comment.
It's more complicated in Polish:
1 year - 1 rok
2,3,4 years - 2,3,4 lata
5,6,7... years - 5,6,7... lat
There was a problem hiding this comment.
It's not as simple in Polish as in English, but... I'm working on your above example.
1 rok
2 lata, 3 lata, 4 lata
5 lat, 6 lat and so on...
There was a problem hiding this comment.
No worries @jrushlow, I wouldn't think that way. I know that this is how it works. I would do the same. Thank you for your time developing all of this and maintaining it.
There was a problem hiding this comment.
It really depends on sentence translation. My translation (and not only my) was: Ten link wygaśnie za ..., so 1 rok is correct. In your translation (Link wygaśnie w ciągu ...) 1 roku is also correct. So have to take just one convention.
There was a problem hiding this comment.
Indeed, that is a bummer. OK, so probably this would be a better option to have 3 different forms as it is more popular. But should be the whole sentence put in translations too so that there are no problems like this in the future? I would be for this option. Put the whole sentence int the translation to get proper context or do not put it at all and leave it up to the developer how to proceed. So just leave getExpirationMessageData method and skip getExpirationMessageKey.
There was a problem hiding this comment.
It really depends on sentence translation. My translation (and not only my) was:
Ten link wygaśnie za ..., so1 rokis correct. In your translation (Link wygaśnie w ciągu ...)1 rokuis also correct. So have to take just one convention.
To me
- wygaśnie za is more exact: wygaśnie w ciągu sounds like a process of expiration (expires during a year…).
- With the wygaśnie za phrase the grammar gender of the following time term is easier to express/maintain in Polish because of the accusative form that coincides with the nominative one: "rok", "miesiąc", "tydzień", "dzień" and so on have no suffixes (za rok => w ciągu roku) nor fancy declesions (za tydzień => w ciągu tygodnia, za miesiąc => w ciągu miesiąca); but: godzina [hour]: za godzinę > w ciągu godziny.
There was a problem hiding this comment.
I agree, but as wrote above I recommend to use the full sentence in the translation or do not translate it at all in the bundle and leave the whole to the developer. Both solutions would be good so that we do not have to spend time on discussions like these :)
|
@marmichalski any chance you could verify these translations if you have some free time? Thanks in advance! |
| <body> | ||
| <trans-unit id="1"> | ||
| <source>%count% year|%count% years</source> | ||
| <target>%count% roku|%count% lat</target> |
There was a problem hiding this comment.
It's more complicated in Polish:
1 year - 1 rok
2,3,4 years - 2,3,4 lata
5,6,7... years - 5,6,7... lat
|
@weaverryan any reason to use the old Symfony-specific format in the bundle rather than the ICU format ? The bundle requires Symfony 4.4+, so it has access to the ICU format |
|
It would be nice to be able to use this code already :) When are you planning to merge and release new version? |
@stof - probably not :). Though I personally understand the new format less. We were kind of following the standard in Symfony itself. @jrushlow it looks like this has a review on it - so we could use that to push things forward. |
jrushlow
force-pushed
the
feature/polish-translations
branch
from
4951abb
to
26fbb60
Compare
mirrors SymfonyCasts/reset-password-bundle#149
Context:
This link will expire in 1 yearwhich in Polish isLink wygaśnie w ciągu 1 rokuThis link will expire in 3 yearswhich in Polish isLink wygaśnie w ciągu 3 latThis link will expire in 5 yearswhich in Polish isLink wygaśnie w ciągu 5 latThis link will expire in 6 yearswhich in Polish isLink wygaśnie w ciągu 6 latThis link will expire in 17 yearswhich in Polish isLink wygaśnie w ciągu 17 latthe same context applies for
month|months,day|days,hour|hours,minute|minutes