Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak investigation: 0.2.7-0.2.8 might enter an infinite loop when crawling node_modules due to symlinks #54

Closed
SuperchupuDev opened this issue Oct 1, 2024 · 1 comment
Closed

Memory leak investigation: 0.2.7-0.2.8 might enter an infinite loop when crawling node_modules due to symlinks #54

SuperchupuDev opened this issue Oct 1, 2024 · 1 comment
Labels
bug Something isn't working performance Potential performance improvement

Comments

@SuperchupuDev
Copy link
Owner

SuperchupuDev commented Oct 1, 2024 •
edited
Loading

0.2.7 added symlinks resolution, but by the looks of it it might enter an infinite loop or just be extremely slow due to how node_modules are linked to each other in pnpm

i've just released 0.2.9 that reverts symlinks resolution until we figure out a fix

can reproduce with a directory symlink that points to a parent directory of itself, upstream fdir issue: thecodrr/fdir#125

issue has been fixed upstream thecodrr/fdir#126, not released yet

will update the comment as any developments happen
@SuperchupuDev SuperchupuDev added the bug Something isn't working label Oct 1, 2024
SuperchupuDev added a commit that referenced this issue Oct 1, 2024
@SuperchupuDev
revert resolution of symbolic links due to #54
1f1fa12
@SuperchupuDev SuperchupuDev mentioned this issue Oct 1, 2024
Closed
@SuperchupuDev SuperchupuDev added the performance Potential performance improvement label Oct 1, 2024
@ghiscoding ghiscoding mentioned this issue Oct 1, 2024
Merged
@SuperchupuDev SuperchupuDev changed the title Memory leak investigation: might enter infinite loop when crawling node_modules due to symlinks Memory leak investigation: 0.2.7-0.2.8 might enter an infinite loop when crawling node_modules due to symlinks Oct 1, 2024
@SuperchupuDev SuperchupuDev changed the title Memory leak investigation: 0.2.7-0.2.8 might enter an infinite loop when crawling node_modules due to symlinks Memory leak investigation: 0.2.7-0.2.8 might enter an infinite loop when crawling node_modules due to symlinks Oct 1, 2024
@SuperchupuDev SuperchupuDev mentioned this issue Oct 7, 2024
Closed
@SuperchupuDev
Copy link
Owner Author

fdir 6.4.2 solved this, next release should make symlinks work again without this problem 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working performance Potential performance improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SuperchupuDev