Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behavior: node_modules Ignored when combined with other patterns #58

Closed
j0nl1 opened this issue Oct 7, 2024 · 2 comments
Closed
Labels
duplicate This issue or pull request already exists

Comments

@j0nl1
Copy link

j0nl1 commented Oct 7, 2024

I'm not sure if this is the expected behavior, but it seems quite different from how fast-glob works. Essentially, when adding the node_modules folder and another pattern, the node_modules directory is ignored completely.

You can find a simple example reproducing this issue here:
https://stackblitz.com/edit/tinyglobby-behavior?file=glob.ts&view=editor

Is this the intended behavior? Any clarification would be appreciated!

Thanks in advance.

@SuperchupuDev
Copy link
Owner

the node_modules folder generated by pnpm contains symlinks to packages from node_modules/.pnpm. sadly symlinks resolution had to be temporarily reverted due to a critical upstream bug, it will be reenabled once it gets fixed. you can track the following issues meanwhile:

in theory, it should work once symlinks resolution is added back. meanwhile, i'm closing this as a duplicate of #10

by the way, unrelated to symlinks: you should set the expandDirectories tinyglobby option to false if you want to match fast-glob's behavior as much as possible

@SuperchupuDev SuperchupuDev closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2024
@SuperchupuDev SuperchupuDev added the duplicate This issue or pull request already exists label Oct 7, 2024
@SuperchupuDev
Copy link
Owner

SuperchupuDev commented Oct 25, 2024

fixed in 0.2.10. can you confirm that the issue is solved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants