Feat: Added Credential Schema Service #219
Conversation
|
|
||
| } | ||
|
|
||
| async verify(template: string, schemaID: string): Promise<boolean> { |
There was a problem hiding this comment.
better name instead of verify
There was a problem hiding this comment.
Updated to a more descriptive name, please verify that it is appropriate.
| }); | ||
| }*/ | ||
|
|
||
| async credentialSchema( |
There was a problem hiding this comment.
should it be getCredentialSchema
There was a problem hiding this comment.
Yes, thanks for pointing that out!
| if (templateToBeDeleted.deleted == true) { | ||
| throw new NotFoundException('Record not found'); | ||
| } | ||
| const template = await this.prisma.template.update({ |
There was a problem hiding this comment.
findUnique can be avoided right? directly update without fetching
There was a problem hiding this comment.
The function is a soft delete, changing a property called 'deleted' to signify that the template is deleted.
The first 'findUnique' is looking up whether the 'deleted' property is already true, before carrying out the soft delete.
Let me know if we should remove the findUnique function anyway.
|
|
||
| async verify(template: string, schemaID: string): Promise<boolean> { | ||
| try{ | ||
| let HBSfields: Array<string> = this.parseHBS(template); |
There was a problem hiding this comment.
variable can start with lower case
| status: data.status, | ||
| // updatedBy: | ||
|
|
||
| }, |
There was a problem hiding this comment.
only the data to query is changing, can only that be extracted
| } | ||
|
|
||
| datasource db { | ||
| provider = "postgresql" |
There was a problem hiding this comment.
move to environment variable.
There was a problem hiding this comment.
the solution for this will be raised as a separate PR for all three services
fix: Refactor tests to run dependents services first
fix: generate did in tests
…to refactor-schema
Refactor schema
| author: string; | ||
| authored: Date; | ||
| schema: any; //VCSchema | ||
| // proof?: { |
There was a problem hiding this comment.
Please remove commented code.
|
@techsavvyash @tushar5526 can you add test coverage screenshot like identity service. This PR is approved. Once coverage snapshot is added, I will merge it in. |
…to refactor-schema
fix: updation logic
fix: add error on invalid status type
|
No description provided.