Feat: Credential Service #217

techsavvyash · 2023-04-18T11:49:04Z

Description

This PR contains the actual code for the Credential service unlike the previous PR which was submodules based.

Signed-off-by: Yash Mittal <mittal.yash12@hotmail.com> Feat: Add credentials-service Signed-off-by: Yash Mittal <mittal.yash12@hotmail.com>

Signed-off-by: Yash Mittal <mittal.yash12@hotmail.com>

tejash-jl · 2023-04-24T04:48:28Z

...s/credentials-service/prisma/migrations/20230304094253_migrate_mongodb_to_psql/migration.sql

+CREATE TYPE "VCStatus" AS ENUM ('PENDING', 'ISSUED', 'REVOKED');
+
+-- CreateTable
+CREATE TABLE "VC" (


is this for storing credential schema?

This table has been deprecated and will be removed. Initially it was meant to store the issued credentials in the postgres db associated with the credentials service.

tejash-jl · 2023-04-24T04:48:46Z

...s/credentials-service/prisma/migrations/20230304094253_migrate_mongodb_to_psql/migration.sql

+);
+
+-- CreateTable
+CREATE TABLE "VCV2" (


what is this table used for?

Since the APIs are not connected with the registry right now, so we have a postgres instance associated wih the credential service to save the issued credentials in the postgres instance. This table stores those credentials.

we need to fix the table name

Will rename this to "VerifiableCredentials".

are these fixed? @techsavvyash

tejash-jl · 2023-04-24T04:53:04Z

...s/credentials-service/prisma/migrations/20230304094253_migrate_mongodb_to_psql/migration.sql

+);
+
+-- CreateTable
+CREATE TABLE "Counter" (


you can use SERIAL pseudo-type

techsavvyash · 2023-06-15T14:29:17Z

Hey @tejash-jl,
If everything is aligned can we merge this PR and #218 and #219 ?
Thanks

cc: @ChakshuGautam

tejash-jl · 2023-06-19T11:18:10Z

remove commented codes

tejash-jl · 2023-06-19T11:18:30Z

integrate e2e test to the top level Makefile

tejash-jl · 2023-06-20T14:50:36Z

@techsavvyash you would need to document about this service here,

https://github.com/Sunbird-RC/community
document the APIs as well

tejash-jl · 2023-06-20T15:03:21Z

Create e2e tests for all v2 APIs
Existing tests are present here, https://github.com/Sunbird-RC/sunbird-rc-core/tree/main/java/apitest/src/test/java/e2e/registry

feat: Add targets for credentials service

srprasanna · 2023-07-10T06:49:03Z

Makefile

@@ -41,16 +43,16 @@ test: build
 	@echo "Starting the test" && sh build/wait_for_port.sh 8081
 	@docker-compose ps
 	@curl -v http://localhost:8081/health
-	@cd java/apitest && ../mvnw -Pe2e test || echo 'Tests failed'
+	@cd java/apitest && ../mvnw -Pe2e test


Could you add the tests failure message as well.

Currently, the services will throw an error and fail the test target if any test fails with the test report. Adding an '||condition will not fail the Makefile'stest` target, probably.

srprasanna · 2023-07-10T06:49:35Z

java/apitest/src/test/java/e2e/registry/registry.feature

@@ -223,7 +223,7 @@ Feature: Registry api tests
    When method post
    Then status 200
    And response.result.Teacher.transactionId.length > 0
-    * sleep(3000)
+    * sleep(7000)


Why is this changed.

This happened due to one of the rebase probably, undid all these changes.

srprasanna · 2023-07-10T06:49:57Z

java/apitest/src/test/java/e2e/registry/registry.feature

@@ -468,10 +468,10 @@ Feature: Registry api tests
    And response.params.errmsg == "Schema 'Teacher1' not found"
 # patch unavailable schema with sign
    Given url registryUrl
-    And path '/api/v1/Teacher/sign'
+    And path '/api/v1/Teacher1/sign'


Why was this changed.

resolved to original

srprasanna · 2023-07-10T06:50:17Z

java/apitest/src/test/java/e2e/registry/registry.feature

    And header Authorization = admin_token
    And request read('TeacherRequest.json')
-    When method patch
+    When method get


Why is this changed.

reverted to original

srprasanna · 2023-07-10T06:55:26Z

services/credentials-service/src/credentials/credentials.service.spec.ts

+    }
+  });
+
+  // it('should show a stremable file', async () => {


Please remove comments.

done, thanks

srprasanna · 2023-07-10T06:56:04Z

services/credentials-service/src/credentials/dto/getCredentialById.dto.ts

+import { Extensible } from "did-resolver";
+
+
+// class Credential implements W3CCredential {


Remove commented Code.

done, thanks

…rc-core into credential

tushar5526 · 2023-07-11T14:18:16Z

srprasanna · 2023-07-17T07:48:57Z

services/identity-service/docker-compose.yml

@@ -50,7 +48,7 @@ services:
      VAULT_ADDR: "http://vault:8200"
      # This will be replaced automatically on initialisation 
      # make compose-init will call setup_vault.sh
-      VAULT_TOKEN: hvs.ZBCv64FQYZibBmfa6cgcc8ls
+      VAULT_TOKEN: hvs.ANn8uBxHYvRCv5Q3FXuqzoIG


Can you move these to .env file.

srprasanna · 2023-07-17T07:50:48Z

Can you try to increase overall coverage. Some of the files have about 40-50% coverage. Can you look at the credential service and controller.

tushar5526 · 2023-07-18T06:23:54Z

I have increased the test coverage. Please take a look. 72-101 line in the controller is tested in e2e tests but not reflected here. It is the header parsing logic for accept header

tushar5526 · 2023-07-18T06:26:23Z

Moving to vault token to .env will require a bit of refactoring in all 3 services and I am planning to make it as a different PR. For now, I am just removing it from the compose.

techsavvyash added 3 commits April 18, 2023 17:03

Feat: Add credentials-service

1f2d16c

Signed-off-by: Yash Mittal <mittal.yash12@hotmail.com> Feat: Add credentials-service Signed-off-by: Yash Mittal <mittal.yash12@hotmail.com>

Cleanup: Remove dist folder

3169c3a

Signed-off-by: Yash Mittal <mittal.yash12@hotmail.com>

Cleanup: Remove unnecessary folders

9cda756

Signed-off-by: Yash Mittal <mittal.yash12@hotmail.com>

techsavvyash marked this pull request as draft April 18, 2023 12:42

tejash-jl reviewed Apr 24, 2023

View reviewed changes

techsavvyash marked this pull request as ready for review June 15, 2023 08:57

fix: resolve comments on table naming

32c18e0

techsavvyash requested a review from tejash-jl June 15, 2023 09:26

fix: update schema.mongo

e45799f

techsavvyash mentioned this pull request Jun 19, 2023

Master Ticket - Contribution to RC Unified-Learner-Passbook/Credential-MS#54

Open

15 tasks

fix: remove comments

9cae2c0

techsavvyash added 8 commits June 19, 2023 18:55

fix: clean up comments

f19713a

fix: embedded url in QRCode, add proof in search

98d0a17

refactor

aafc2fe

fix

a4b7b86

feat: allow for adding issuance date on the fly

2809468

fix: remove migration sqls

71bd3c1

feat: paginate bulk search APIs

acbdf08

fix: search APIs returning 404 at the end of pages

cbe3e9a

techsavvyash mentioned this pull request Jun 20, 2023

[RFC]: Combine /claim and /sign into /issue Sunbird-RC/community#726

Open

tushar5526 added 3 commits June 20, 2023 12:17

feat: Add targets for credentials service

2831f8a

feat: Add containerized tests

6b9f7b2

feat: Update Makefile for tests

02f9f3a

techsavvyash and others added 2 commits June 21, 2023 14:10

Merge pull request #2 from tushar5526/credential

97681c9

feat: Add targets for credentials service

feat: club /render in GET /{id} based on headers

294dfc1

tushar5526 and others added 3 commits July 7, 2023 11:07

fix: Fix paths for credential schema

df5462d

fix: Change port to 3000

b5abd34

Update package.json

1e5942d

srprasanna reviewed Jul 10, 2023

View reviewed changes

tushar5526 and others added 13 commits July 10, 2023 07:27

fix: undo rebase changes

9f5ea04

fix: resolve rebase changes

36ddf96

fix: remove commented code

de2d294

fix: remove comments

32954b4

fixes

13a35cc

Merge branch 'credential' of https://github.com/techsavvyash/sunbird-…

05722ed

…rc-core into credential

Merge branch 'release-2.0.0' into credential

3a964c0

feat: add schema version and cleanups

bc1f252

fix: add tests and fix docker compose

eee297b

feat: refactor code and add logging

eb68247

feat: update makefiles for tests

45add62

feat: add docker compose to docker network

f7cda8b

feat: Show code coverage after test runs

ef36e74

srprasanna approved these changes Jul 17, 2023

View reviewed changes

tushar5526 force-pushed the credential branch from 944f47a to 72aa703 Compare July 18, 2023 06:19

fix: add more tests for coverage

9fe42d0

tushar5526 force-pushed the credential branch from 72aa703 to 9fe42d0 Compare July 18, 2023 06:22

fix: unset temporary vault token

c5bace5

tushar5526 added 2 commits July 18, 2023 06:59

fix: Fix String test

95ae687

feat: fix wkhtmltopdf version

e2cc9a0

srprasanna approved these changes Jul 25, 2023

View reviewed changes

srprasanna merged commit f404659 into Sunbird-RC:release-2.0.0 Jul 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: Credential Service #217

Feat: Credential Service #217

techsavvyash commented Apr 18, 2023 •

edited

Loading

tejash-jl Apr 24, 2023

techsavvyash Apr 24, 2023

tejash-jl Apr 24, 2023

techsavvyash Apr 24, 2023

tejash-jl Apr 25, 2023

techsavvyash Apr 26, 2023

tejash-jl Jun 19, 2023

tejash-jl Apr 24, 2023

techsavvyash commented Jun 15, 2023

tejash-jl commented Jun 19, 2023

tejash-jl commented Jun 19, 2023

tejash-jl commented Jun 20, 2023

tejash-jl commented Jun 20, 2023

srprasanna Jul 10, 2023

tushar5526 Jul 10, 2023

srprasanna Jul 10, 2023

tushar5526 Jul 10, 2023

srprasanna Jul 10, 2023

tushar5526 Jul 10, 2023

srprasanna Jul 10, 2023

tushar5526 Jul 10, 2023

srprasanna Jul 10, 2023

tushar5526 Jul 10, 2023

srprasanna Jul 10, 2023

tushar5526 Jul 10, 2023

tushar5526 commented Jul 11, 2023

srprasanna Jul 17, 2023

srprasanna commented Jul 17, 2023

tushar5526 commented Jul 18, 2023

tushar5526 commented Jul 18, 2023

		import { Extensible } from "did-resolver";


		// class Credential implements W3CCredential {

Feat: Credential Service #217

Feat: Credential Service #217

Conversation

techsavvyash commented Apr 18, 2023 • edited Loading

Description

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

techsavvyash commented Jun 15, 2023

tejash-jl commented Jun 19, 2023

tejash-jl commented Jun 19, 2023

tejash-jl commented Jun 20, 2023

tejash-jl commented Jun 20, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tushar5526 commented Jul 11, 2023

Choose a reason for hiding this comment

srprasanna commented Jul 17, 2023

tushar5526 commented Jul 18, 2023

tushar5526 commented Jul 18, 2023

techsavvyash commented Apr 18, 2023 •

edited

Loading