FMOD fade-outs #564
Merged
FMOD fade-outs #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeTwentyThree
requested changes
Nov 12, 2024
| channel.stop(); | ||
| return false; | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| channel.getDelay(out ulong _, out ulong _, out bool stopChannels); | |
| if (stopChannels) | |
| return false; | |
This prevents unnecessary and conflicting fade points from cluttering the sound channel.
LeeTwentyThree
approved these changes
Nov 13, 2024
JKohlman
reviewed
Dec 23, 2024
| @@ -761,14 +778,22 @@ public static bool FMOD_CustomEmitter_Play_Prefix(FMOD_CustomEmitter __instance) | |||
|
|
|||
| [HarmonyPatch(typeof(FMOD_CustomEmitter), nameof(FMOD_CustomEmitter.Stop))] | |||
| [HarmonyPrefix] | |||
| public static bool FMOD_CustomEmitter_Stop_Prefix(FMOD_CustomEmitter __instance) | |||
| public static bool FMOD_CustomEmitter_Stop_Prefix(FMOD_CustomEmitter __instance, STOP_MODE stopMode) | |||
There was a problem hiding this comment.
Causes #573. This method in BZ doesn't take a STOP_MODE parameter.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in this pull request
You can add a fade-out point using one of the two methods:
Soundobject when you're creating one. This makes the Sound always fade-out when fading is allowedREQUIRES THOROUGH TESTING