Fix blob support in Node #955
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #941.
Node has
Blob
but notFileReader
. Instead, we can convert a blob's contents to anArrayBuffer
usingBlob.prototype.arrayBuffer
.This approach should stick pretty closely to what the code already does (transparently try to convert a
Blob
to anArrayBuffer
before doing anything else to it).I've also fixed the test code so that it doesn't try to read certain properties of the passed blob unless it's actually a
Blob
--if that particular test helper is called with an error, theblob
argument will benull
, and we'll get spurious errors that terminate the entire test suite early.