Node.js tests are failing since introduction of `Blob` global

[jonkoops]

Node.js 18.x introduced support for Blob as a global, which is causing the tests to fail. There seems to be a bug in the JSZip that wasn't previously caught, and I suspect it has to do with the fact that there is no input type for Blob. This seems to indicate it was never fully supported, but I'll have to dive deeper to be sure.

[jonkoops]

As part of the resolution of this issue, the Node.js matrix on CI should be modified to include all versions of Node.js 18 and up.

[julienw]

I have a similar problem with ArrayBuffers, when used with a fetch Response's arrayBuffer function.

I think the issue is in these lines:

jszip/lib/utils.js

Lines 361 to 366 in 643714a

	if (support.uint8array && input instanceof Uint8Array) {
	return "uint8array";
	}
	if (support.arraybuffer && input instanceof ArrayBuffer) {
	return "arraybuffer";
	}

We'd need to use Object.prototype.toString.apply to check the type.

Blob might be the same problem, because blob values are first read into a buffer in

jszip/lib/utils.js

Lines 457 to 468 in 643714a

	if (isBlob && typeof FileReader !== "undefined") {
	return new external.Promise(function (resolve, reject) {
	var reader = new FileReader();
	reader.onload = function(e) {
	resolve(e.target.result);
	};
	reader.onerror = function(e) {
	reject(e.target.error);
	};
	reader.readAsArrayBuffer(data);
	});

If I make a patch for that, would you be happy to merge and release a new version?

[julienw]

My workaround for the Arraybuffer case is to wrap it in a new Uint8Array, which has the right constructor then.