Exclude LC0052 and LC0053 on procedure which implements an interface #572
Conversation
| public MethodSymbolAnalyzer(CompilationAnalysisContext compilationAnalysisContext) | ||
| { | ||
| NavAppManifest manifest = ManifestHelper.GetManifest(compilationAnalysisContext.Compilation); | ||
|
|
||
| if (manifest.InternalsVisibleTo != null && manifest.InternalsVisibleTo.Any()) | ||
| { |
There was a problem hiding this comment.
I am surprised to see the curly brackets getting removed though (and all the non-redundant whitespace) 😮
It is good practice to have curly brackets in C# even if there is only a single statement.
There was a problem hiding this comment.
As a novice level C# developer I though I was improving readability of the code by removing the curly brackets.
I thought if it is a one liner, the code is cleaner to have it without curly braces. Even maybe put it in one nice and short line. After all, C# compiler allows it, who am I to disagree with that? Boy, was I wrong 😯
@rvanbekkum, I genuinely appreciate you feedback on this. I've learned why you should always use curly braces for single statement blocks in C#. I'll revert these changes with a new PR.
There was a problem hiding this comment.
I suspect it wouldn't be as much of a problem with C# if it would always apply a formatter automatically like what happens for AL code. 🙂
…OnRule0052 Exclude LC0052 and LC0053 on procedure which implements an interface #572
No description provided.