Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude LC0052 and LC0053 on procedure which implements an interface #572 #576

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

Arthurvdv
Copy link
Collaborator

No description provided.

@Arthurvdv
Copy link
Collaborator Author

@rvanbekkum I've moved the validation for interfaces of a method up in the chain. Do you see any problems with this approach

var objectSymbol = methodSymbol.GetContainingApplicationObjectTypeSymbol();

Is there a benefit of casting this with a var instead of IApplicationObjectTypeSymbol? I've changed this , where I believe I don't need validate the methodSymbol.ContainingSymbol is IApplicationObjectTypeSymbolanymore?

@Arthurvdv Arthurvdv merged commit e527189 into prerelease Apr 3, 2024
@Arthurvdv Arthurvdv deleted the InternalProcedureOfInterfaceOnRule0052 branch April 3, 2024 16:33
@rvanbekkum
Copy link
Contributor

@rvanbekkum I've moved the validation for interfaces of a method up in the chain. Do you see any problems with this approach

var objectSymbol = methodSymbol.GetContainingApplicationObjectTypeSymbol();

Is there a benefit of casting this with a var instead of IApplicationObjectTypeSymbol? I've changed this , where I believe I don't need validate the methodSymbol.ContainingSymbol is IApplicationObjectTypeSymbolanymore?

I have checked the changes and they look good to me ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants