Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk: don't allow mounts in inject actions #1653

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

chrisguida
Copy link
Contributor

@chrisguida chrisguida commented Jul 15, 2022

Fixes: #557

Proof:
Screen Shot 2022-07-14 at 7 02 13 PM
Screen Shot 2022-07-14 at 7 02 46 PM

@chrisguida chrisguida requested a review from dr-bonez July 15, 2022 00:01
@dr-bonez dr-bonez changed the base branch from master to next July 15, 2022 20:25
@dr-bonez
Copy link
Member

since verify() is invoked on package install as well, we may need to only run this check if manifest.eos-version >= 0.3.2

@chrisguida
Copy link
Contributor Author

chrisguida commented Jul 15, 2022

I'd prefer to know on the pack/verify step. having to wait until the install step introduces lag into the build/deploy cycle

@chrisguida
Copy link
Contributor Author

Or perhaps I'm misunderstanding

@dr-bonez
Copy link
Member

It does both

@dr-bonez dr-bonez changed the base branch from next to master July 18, 2022 18:25
@dr-bonez dr-bonez added this to the 0.3.1.1 milestone Jul 18, 2022
@dr-bonez dr-bonez added the Enhancement New feature or request label Jul 18, 2022
@dr-bonez dr-bonez merged commit 009f7dd into master Jul 18, 2022
@MattDHill MattDHill deleted the feat/sdk-no-mounts-in-inject-actions branch August 2, 2022 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forbid inject: true and mount: ... in manifest
2 participants