v2.3.13 #14
v2.3.13 #14
Conversation
|
This fixed an issue for a user I had with database errors as expected. |
| image.tar: Dockerfile docker_entrypoint.sh health-check.sh example.env | ||
| docker buildx build --tag start9/$(PKG_ID)/main:$(PKG_VERSION) --platform=linux/arm64 -o type=docker,dest=image.tar . |
There was a problem hiding this comment.
Why remove DOCKER_CLI_EXPERIMENTAL=enabled? Is this no longer needed?
There was a problem hiding this comment.
Why remove
DOCKER_CLI_EXPERIMENTAL=enabled? Is this no longer needed?
updated to use the new Makefile format from hello-world example.
There was a problem hiding this comment.
...I assume the new hello-world was tested and works, and doesn't require this flag anymore?
docker_entrypoint.sh
Outdated
| # export OLD_PASSWORD=$(su - postgres -c 'psql -d '$POSTGRES_DB' -c "select password from users limit 1"') | ||
| # sed -i "s/$POSTGRES_PASSWORD/$OLD_PASSWORD/" /media/start9/stats.yaml | ||
| # export POSTGRES_PASSWORD=$OLD_PASSWORD | ||
| # fi |
There was a problem hiding this comment.
What's this comment block for? Are we migrating old data somewhere else?
There was a problem hiding this comment.
we pull metadata from filebrowser on first run
| @@ -35,10 +39,13 @@ migrations: | |||
| entrypoint: migration-from-lt-2-3-9.sh | |||
| args: [] | |||
| io-format: json | |||
| inject: true | |||
| inject: false | |||
There was a problem hiding this comment.
was throwing an error. I'm assuming this is because of the OS updates
There was a problem hiding this comment.
Did you test? I seriously doubt this was the correct solution
There was a problem hiding this comment.
I cannot test it because there is not a version earlier than 2.3.9 on the marketplace
There was a problem hiding this comment.
That means that that migration is for people updating from 0.2.x. We'll have to test that so users can migrate from 0.2.x.
There was a problem hiding this comment.
I'm guessing this is ok actually. It looks like mounts were added even though inject was true, which actually errors out in docker. I'm surprised this migration ever worked at all: dc79457
There was a problem hiding this comment.
We have since started catching this misconfiguration: Start9Labs/start-os#1653
|
I should add - the password for PV got changed during this upgrade - that's probably not intentional. |
this is very intentional. the old password formats do not migrate properly. |
…toview-wrapper into migration/v2.3.13
islandbitcoin
force-pushed
the
migration/v2.3.13
branch
from
f021dfc to
e58620f
Compare
|
Beta testing is well underway, I think this code is ready to be merged? @chrisguida |
Migration to PostgreSQL DB and version bump