Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/memory leak docker #1505

Merged
merged 7 commits into from
Jun 7, 2022
Merged

Fix/memory leak docker #1505

merged 7 commits into from
Jun 7, 2022

Conversation

Blu-J
Copy link
Contributor

@Blu-J Blu-J commented Jun 7, 2022

About

Found issues during the memory leak fix

Proof

This was having an issue, now returns
image
image

And as for the only error is also persistent in pre - memory leak fix
image

@Blu-J Blu-J requested a review from dr-bonez June 7, 2022 17:48
@@ -479,27 +475,28 @@ async fn buf_reader_to_lines(
Ok(output)
}

async fn max_buffer(
async fn max_by_lines(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So make it so I don't have to go to vec to early and I avoided the issue that the buffer was wrong for the serialize, so glad that got fixed. And this makes more sense to keep it in string

@dr-bonez dr-bonez merged commit 9217d00 into master Jun 7, 2022
@Blu-J Blu-J deleted the fix/memory-leak-docker branch June 7, 2022 20:54
@Blu-J Blu-J mentioned this pull request Jun 8, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants