[bug]: [UI]: Memory Leak

[chrisguida]

Prerequisites

• I have searched for existing issues that already report this problem, without success.

EmbassyOS Version

0.3.0

Device

Laptop/Desktop

Device OS

MacOS

Device OS Version

11.6.4

Browser

Firefox

Browser Version

98.0.1

Current Behavior

Left the bitcoind service detail tab open for a few days and it was using 13GB of ram.

Expected Behavior

The UI should probably never need more than a few MB of RAM.

Steps to Reproduce

1. Open bitcoind service details page
2. Leave open for a few days

Anything else?

No response

[Blu-J]

So, for firefox, no memory leak detected

For Brave + mocks / my embassy, no leaks detected. The only allocation is in collectIfNeeded and is cleaned up like it should. See Below

The code found, which is my vaultwarden plugin

    function collectIfNeeded() {
        if (pageHref !== window.location.href) {
            pageHref = window.location.href;
            if (observer) {
                observer.disconnect();
                observer = null;
            }
            collect();
            if (observeDomTimeout != null) {
                window.clearTimeout(observeDomTimeout);
            }
            observeDomTimeout = window.setTimeout(observeDom, 1000);
        }
        if (collectIfNeededTimeout != null) {
            window.clearTimeout(collectIfNeededTimeout);
        }
        collectIfNeededTimeout = window.setTimeout(collectIfNeeded, 1000);
    }

Has nothing that looks like a leak. and the collect is just calling a chrome extension.

[Blu-J]

And the states for the check indicators are

Blue Pi

Black Pi

Mocks

[Blu-J]

Next time, could we capture the
memory snapshot

and the dom since there was a #document increasing for @MattDHill box

[chrisguida]

What specifically should I capture next time I see this?

[Blu-J]

savingSnapshot.mp4

copyingHtml.mp4

[chrisguida]

Awesome, thanks so much @Blu-J ! Will definitely do this next time I see this leak.

Btw what software are you using to make these videos?

[Blu-J]

I should have a fix via #1505
Should see this fixed in the beta + master today

[Blu-J]

Haven't seen this in a while, and then if we do please capture everything that is needed. Hars, snapshots, ...