Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

st2chatops also may need proxies #239

Merged
merged 2 commits into from
Apr 8, 2019
Merged

st2chatops also may need proxies #239

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3baf34a
st2chatops also may need proxies
lingfish Apr 8, 2019
dace60d
Merge branch 'master' into patch-3
armab Apr 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion roles/StackStorm.st2/tasks/proxy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
# NB: Empty ENV var cast to 'None' string in Ansible
state: "{{ 'present' if ansible_facts.env.get(item.1, 'None') != 'None' else 'absent' }}"
vars:
_services: [st2api, st2actionrunner]
_services: [st2api, st2actionrunner, st2chatops]
Copy link
Member

@arm4b arm4b Apr 8, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking closer, this addition should belong to st2chatops Ansible role as it could be installed separately.

Would be great to move it from StackStorm.st2 to StackStorm.st2chatops instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, how can we do this when this one has already been merged?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just open another PR that adds to st2chatops and removes from st2

_proxy_vars: [http_proxy, https_proxy, no_proxy]
loop: '{{ _services|product(_proxy_vars)|list }}'
notify:
Expand Down