-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
st2chatops also may need proxies #239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense 👍
Thanks for the contribution!
looks like lower-case http_proxy
and https_proxy
should work well according to slackapi/hubot-slack#372 (comment)
@@ -10,7 +10,7 @@ | |||
# NB: Empty ENV var cast to 'None' string in Ansible | |||
state: "{{ 'present' if ansible_facts.env.get(item.1, 'None') != 'None' else 'absent' }}" | |||
vars: | |||
_services: [st2api, st2actionrunner] | |||
_services: [st2api, st2actionrunner, st2chatops] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After looking closer, this addition should belong to st2chatops
Ansible role as it could be installed separately.
Would be great to move it from StackStorm.st2
to StackStorm.st2chatops
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, how can we do this when this one has already been merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just open another PR that adds to st2chatops
and removes from st2
Otherwise it can't connect to RTM on Slack, for example.