Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to minimum of Ansible 2.5 (resolves #190) #215

Merged
merged 8 commits into from
Dec 18, 2018

Commits on Nov 10, 2018

  1. Ansible 2.5 | Use loop instead of with_*

    Replaces `with_*` loops with the new `loop` keyword.[1]
    
    Note that with_dict => loop uses the dictsort filter as dict2items is
    not available until Ansible 2.6.
    
    [1] https://docs.ansible.com/ansible/2.7/porting_guides/porting_guide_2.5.html#migrating-from-with-x-to-loop
    tzyychin authored and cognifloyd committed Nov 10, 2018
    Configuration menu
    Copy the full SHA
    138cfc5 View commit details
    Browse the repository at this point in the history
  2. Ansible 2.5 | Use import_tasks for static includes

    Replaces static includes with import_tasks (partially resolves StackStorm#190).
    tzyychin authored and cognifloyd committed Nov 10, 2018
    Configuration menu
    Copy the full SHA
    746920a View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2018

  1. Ansible 2.5 | Use include_tasks for dynamic includes

    Replaces dynamic includes with include_tasks (resolves StackStorm#190).
    
    include_tasks (introduced in Ansible 2.4) does not support ansible 1.x
    style inline vars syntax (var=value) (since at least Ansible 2.4.1)[1].
    If the syntax ever worked, removing support for it was announced in the
    Ansible 2.7 Porting Guide[2]. So, this modifies include loops to be
    include_tasks loops using the `vars` key instead of the inline syntax.
    
    [1] ansible/ansible#32812
    [2] https://docs.ansible.com/ansible/2.7/porting_guides/porting_guide_2.7.html#include-tasks-import-tasks-inline-variables
    tzyychin authored and cognifloyd committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    5dd6be8 View commit details
    Browse the repository at this point in the history
  2. Ansible 2.5 | Apply tags to include_tasks tasks

    Dynamic includes (include_tasks) do not apply tags to internal tasks.[1]
    Once we transition to 2.7, we can use `apply` on the `include_tasks`
    module to specify the tags for included files.[2]
    
    [1] https://docs.ansible.com/ansible/2.7/porting_guides/porting_guide_2.5.html#dynamic-includes-and-attribute-inheritance
    [2] https://docs.ansible.com/ansible/2.7/modules/include_tasks_module.html
    cognifloyd committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    c5b0e1c View commit details
    Browse the repository at this point in the history
  3. Ansible 2.5 | bump minimum for remaining roles

    Bump the minimum ansible version for the remaining roles.
    tzyychin authored and cognifloyd committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    7342137 View commit details
    Browse the repository at this point in the history
  4. Ansible 2.5 | Use ansible_facts namespaced vars

    With 2.5, facts are now namespaced under ansible_facts.[1]
    They are still accessible under the ansible_* vars, however that can be
    disabled by setting `inject_facts_as_vars` to False. The default is True
    in 2.5, but "is expected to be set to 'False' in a future release.
    Migrating now means these roles and playbooks do not depend on this
    setting being True.
    
    [1] https://docs.ansible.com/ansible/2.7/porting_guides/porting_guide_2.5.html#ansible-fact-namespacing
    cognifloyd committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    561a182 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ad25be0 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2018

  1. Configuration menu
    Copy the full SHA
    0fbb391 View commit details
    Browse the repository at this point in the history