Port to minimum of Ansible 2.5 (resolves #190) #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces `with_*` loops with the new `loop` keyword.[1] Note that with_dict => loop uses the dictsort filter as dict2items is not available until Ansible 2.6. [1] https://docs.ansible.com/ansible/2.7/porting_guides/porting_guide_2.5.html#migrating-from-with-x-to-loop
Replaces static includes with import_tasks (partially resolves StackStorm#190).
arm4b
suggested changes
Nov 12, 2018
| @@ -5,3 +5,6 @@ | |||
| yum_resository: | |||
| name: "StackStorm_{{ bwc_repo }}" | |||
| state: absent | |||
| tags: | |||
| - BWC repos | |||
There was a problem hiding this comment.
These tags orignally came from:
- roles/bwc/tasks/bwc_repos_setup.yml:
tagson "Handle bwc_license change"include: license.yml - roles/bwc/tasks/license.yml: "Cleanup repo list file from disk"
Since include_tasks can't propagate tags until a later version of ansible, I manually propagated the tags.
If you want me to drop the ewc tag, that's fine.
|
I did a general switch of BWC -> EWC including tags, task names, comments and some readme entries. I did not update variable names, file names, or role names to avoid breaking anyone using these roles. |
arm4b
approved these changes
Nov 12, 2018
cognifloyd
commented
Nov 13, 2018
Replaces dynamic includes with include_tasks (resolves StackStorm#190). include_tasks (introduced in Ansible 2.4) does not support ansible 1.x style inline vars syntax (var=value) (since at least Ansible 2.4.1)[1]. If the syntax ever worked, removing support for it was announced in the Ansible 2.7 Porting Guide[2]. So, this modifies include loops to be include_tasks loops using the `vars` key instead of the inline syntax. [1] ansible/ansible#32812 [2] https://docs.ansible.com/ansible/2.7/porting_guides/porting_guide_2.7.html#include-tasks-import-tasks-inline-variables
Dynamic includes (include_tasks) do not apply tags to internal tasks.[1] Once we transition to 2.7, we can use `apply` on the `include_tasks` module to specify the tags for included files.[2] [1] https://docs.ansible.com/ansible/2.7/porting_guides/porting_guide_2.5.html#dynamic-includes-and-attribute-inheritance [2] https://docs.ansible.com/ansible/2.7/modules/include_tasks_module.html
Bump the minimum ansible version for the remaining roles.
With 2.5, facts are now namespaced under ansible_facts.[1] They are still accessible under the ansible_* vars, however that can be disabled by setting `inject_facts_as_vars` to False. The default is True in 2.5, but "is expected to be set to 'False' in a future release. Migrating now means these roles and playbooks do not depend on this setting being True. [1] https://docs.ansible.com/ansible/2.7/porting_guides/porting_guide_2.5.html#ansible-fact-namespacing
cognifloyd
force-pushed
the
ansible2.5-support
branch
from
ec9cfd1
to
ad25be0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port to Ansible 2.5 (resolves #190)
Thanks to @tzyychin for helping me put this together!