Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mill project file updated. #1520

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Mill project file updated. #1520

merged 4 commits into from
Sep 5, 2024

Conversation

Readon
Copy link
Collaborator

@Readon Readon commented Sep 1, 2024

Closes #

Context, Motivation & Description

Update dependent packages' version and use tester the same as sim, core, lib, tester.

Impact on code generation

Checklist

  • Unit tests were added
  • API changes are or will be documented:

@Readon
Copy link
Collaborator Author

Readon commented Sep 1, 2024

The default is set to 2.12.
use mill tester[].compile could call tester[2.12.18].compile

@Readon
Copy link
Collaborator Author

Readon commented Sep 1, 2024

@KireinaHoro Does this affect your project significantly?

@KireinaHoro
Copy link
Contributor

Pulled locally and tested. Other than you changed the name of the trait CrossTester to Tester, requiring downstream module definitions to change accordingly as well, no other changes needed.

@Dolu1990
Copy link
Member

Dolu1990 commented Sep 2, 2024

Why updating the dependencies ?
In particular, i remember that ivy"net.openhft:affinity:3.21ea1.1", was a real pain to find a version which wasn't broken on one of the platform ^^ (it that isn't broken, better not updating it)

@Readon
Copy link
Collaborator Author

Readon commented Sep 2, 2024

Why updating the dependencies ? In particular, i remember that ivy"net.openhft:affinity:3.21ea1.1", was a real pain to find a version which wasn't broken on one of the platform ^^ (it that isn't broken, better not updating it)

it's copied from sbt version.

@Readon
Copy link
Collaborator Author

Readon commented Sep 3, 2024

The main target is to add test for all scala versions in tests.
Still need to wait com-lihaoyi/mill#3440 solved.

@Dolu1990
Copy link
Member

Dolu1990 commented Sep 3, 2024

Why updating the dependencies ? In particular, i remember that ivy"net.openhft:affinity:3.21ea1.1", was a real pain to find a version which wasn't broken on one of the platform ^^ (it that isn't broken, better not updating it)
it's copied from sbt version.

It would say, don't update that one, it realy broke stuff by the past on some not so known platforms

@Readon
Copy link
Collaborator Author

Readon commented Sep 3, 2024

Why updating the dependencies ? In particular, i remember that ivy"net.openhft:affinity:3.21ea1.1", was a real pain to find a version which wasn't broken on one of the platform ^^ (it that isn't broken, better not updating it)
it's copied from sbt version.

It would say, don't update that one, it realy broke stuff by the past on some not so known platforms

Why updating the dependencies ? In particular, i remember that ivy"net.openhft:affinity:3.21ea1.1", was a real pain to find a version which wasn't broken on one of the platform ^^ (it that isn't broken, better not updating it)
it's copied from sbt version.

It would say, don't update that one, it realy broke stuff by the past on some not so known platforms

I have checked here, it was updated one year ago.

@Dolu1990
Copy link
Member

Dolu1990 commented Sep 3, 2024

I have checked here, it was updated one year ago.

Ahhhhhhhhhhhh
damned XD, sorry i was confused XDXD

All good, feel free to merge when you want ^^

@Readon Readon merged commit 635130d into SpinalHDL:dev Sep 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants