.NET 8 and C# 12: add repros and UTs for rules starting with S in SonarWay #8126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonioaversa
force-pushed
the
antonio/dotnet8-cs12-add-repros-and-uts-s
branch
from
fda9a0c to
6d38c61
Compare
cristian-ambrosini-sonarsource
suggested changes
Oct 4, 2023
There was a problem hiding this comment.
Looks good! I left 2 educational questions + 1 thought to discuss for S3884
analyzers/tests/SonarAnalyzer.UnitTest/Rules/SqlKeywordsDelimitedBySpaceTest.cs
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/Rules/StringFormatValidatorTest.cs
Show resolved
Hide resolved
...rs/tests/SonarAnalyzer.UnitTest/TestCases/SecurityPInvokeMethodShouldNotBeCalled.CSharp12.cs
Outdated
Show resolved
Hide resolved
This reverts commit b88b691.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
cristian-ambrosini-sonarsource
approved these changes
Oct 5, 2023
cristian-ambrosini-sonarsource
deleted the
antonio/dotnet8-cs12-add-repros-and-uts-s
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules affected by .NET 8 and C# 12 for rules starting with
Sin SonarWay.Adds repros:
Adds UTs with .NET 8 and C# 12 features for: