S2275, S3457: Add UTs for collection expressions + refactoring

SonarSource · Oct 4, 2023 · 6d38c61 · 6d38c61
1 parent 4e47d2e
commit 6d38c61
Show file tree

Hide file tree

Showing 12 changed files with 422 additions and 414 deletions.
diff --git a/analyzers/tests/SonarAnalyzer.UnitTest/Rules/StringFormatValidatorTest.cs b/analyzers/tests/SonarAnalyzer.UnitTest/Rules/StringFormatValidatorTest.cs
@@ -30,43 +30,50 @@ public class StringFormatValidatorTest
         [DataTestMethod]
         [DataRow(ProjectType.Product)]
         [DataRow(ProjectType.Test)]
-        public void StringFormatRuntimeExceptionFreeValidator(ProjectType projectType) =>
-            builder.AddPaths("StringFormatRuntimeExceptionFreeValidator.cs")
+        public void StringFormatValidator_RuntimeExceptionFree(ProjectType projectType) =>
+            builder.AddPaths("StringFormatValidator.RuntimeExceptionFree.cs")
                 .AddReferences(TestHelper.ProjectTypeReference(projectType))
                 .Verify();
 
         [DataTestMethod]
         [DataRow(ProjectType.Product)]
         [DataRow(ProjectType.Test)]
-        public void StringFormatTypoFreeValidator(ProjectType projectType) =>
-            builder.AddPaths("StringFormatTypoFreeValidator.cs")
+        public void StringFormatValidator_TypoFree(ProjectType projectType) =>
+            builder.AddPaths("StringFormatValidator.TypoFree.cs")
                 .AddReferences(TestHelper.ProjectTypeReference(projectType))
                 .Verify();
 
         [TestMethod]
-        public void StringFormatEdgeCasesValidator() =>
-            builder.AddPaths("StringFormatEdgeCasesValidator.cs").Verify();
+        public void StringFormatValidator_EdgeCases() =>
+            builder.AddPaths("StringFormatValidator.EdgeCases.cs").Verify();
 
 #if NET
 
         [DataTestMethod]
         [DataRow(ProjectType.Product)]
         [DataRow(ProjectType.Test)]
-        public void StringFormatRuntimeExceptionFreeValidator_CSharp11(ProjectType projectType) =>
-            builder.AddPaths("StringFormatRuntimeExceptionFreeValidator.CSharp11.cs")
+        public void StringFormatValidator_RuntimeExceptionFree_CSharp11(ProjectType projectType) =>
+            builder.AddPaths("StringFormatValidator.RuntimeExceptionFree.CSharp11.cs")
                 .AddReferences(TestHelper.ProjectTypeReference(projectType))
                 .WithOptions(ParseOptionsHelper.FromCSharp11)
                 .Verify();
 
         [DataTestMethod]
         [DataRow(ProjectType.Product)]
         [DataRow(ProjectType.Test)]
-        public void StringFormatTypoFreeValidator_CSharp11(ProjectType projectType) =>
-            builder.AddPaths("StringFormatTypoFreeValidator.CSharp11.cs")
+        public void StringFormatValidator_TypoFree_CSharp11(ProjectType projectType) =>
+            builder.AddPaths("StringFormatValidator.TypoFree.CSharp11.cs")
                 .AddReferences(TestHelper.ProjectTypeReference(projectType))
                 .WithOptions(ParseOptionsHelper.FromCSharp11)
                 .Verify();
 
+        [TestMethod]
+        public void StringFormatValidator_CSharp12() =>
+            builder.AddPaths("StringFormatValidator.CSharp12.cs")
+                .AddReferences(TestHelper.ProjectTypeReference(ProjectType.Product))
+                .WithOptions(ParseOptionsHelper.FromCSharp12)
+                .Verify();
+
 #endif
 
     }

diff --git a/analyzers/tests/SonarAnalyzer.UnitTest/TestCases/StringFormatEdgeCasesValidator.cs b/analyzers/tests/SonarAnalyzer.UnitTest/TestCases/StringFormatEdgeCasesValidator.cs
diff --git a/...ts/SonarAnalyzer.UnitTest/TestCases/StringFormatRuntimeExceptionFreeValidator.CSharp11.cs b/...ts/SonarAnalyzer.UnitTest/TestCases/StringFormatRuntimeExceptionFreeValidator.CSharp11.cs
diff --git a/...yzers/tests/SonarAnalyzer.UnitTest/TestCases/StringFormatRuntimeExceptionFreeValidator.cs b/...yzers/tests/SonarAnalyzer.UnitTest/TestCases/StringFormatRuntimeExceptionFreeValidator.cs
diff --git a/analyzers/tests/SonarAnalyzer.UnitTest/TestCases/StringFormatTypoFreeValidator.CSharp11.cs b/analyzers/tests/SonarAnalyzer.UnitTest/TestCases/StringFormatTypoFreeValidator.CSharp11.cs