-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build step to npm prepare #32
Conversation
See also https://stackoverflow.com/questions/29738381/how-to-publish-a-module-written-in-es6-to-npm for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why /src/ ... does that start at the user's file root??
Luckily not, that would be scary! :) The syntax for # only ignore the TODO file in the current directory, not subdir/TODO
/TODO
# ignore all files in any directory named build
build/ |
@timbl Replying to your question on gitter,
yes, or more precisely, avoids publishing it. So the idea behind the StackOverflow answer I linked to is that you publish only |
We now have 7346f13 which solves part of the problem. |
For consistency, remember to add these kinds of changes to all related mashlib/solid-panes projects. |
Good point! I added an issue to chat-pane. It looks like folder-pane is still in JS, any others you are aware of? |
I guess solid-panes and solid-ui might be the only ones, for now. But have to remember to add them to other projects as we migrate them to TS. |
It's hard to test it without actually tagging @2.0.6 and trying it out, but I think this should probably be enough to fix issue #31.