Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build step to npm prepare #32

Closed
wants to merge 1 commit into from
Closed

Add build step to npm prepare #32

wants to merge 1 commit into from

Conversation

michielbdejong
Copy link
Contributor

It's hard to test it without actually tagging @2.0.6 and trying it out, but I think this should probably be enough to fix issue #31.

@michielbdejong
Copy link
Contributor Author

@michielbdejong michielbdejong requested a review from timbl February 7, 2020 12:59
Copy link
Contributor

@timbl timbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why /src/ ... does that start at the user's file root??

@michielbdejong
Copy link
Contributor Author

Why /src/ ... does that start at the user's file root??

Luckily not, that would be scary! :) The syntax for .npmignore is the same as for .gitignore, see https://git-scm.com/book/en/v2/Git-Basics-Recording-Changes-to-the-Repository#Ignoring-Files.
Specifically "You can start patterns with a forward slash (/) to avoid recursivity." and these two entries in the example on that page:

# only ignore the TODO file in the current directory, not subdir/TODO
/TODO

# ignore all files in any directory named build
build/

@michielbdejong
Copy link
Contributor Author

@timbl Replying to your question on gitter,

What does npmignore of /src/ do ? remove all of the src tree from npm?

yes, or more precisely, avoids publishing it. So the idea behind the StackOverflow answer I linked to is that you publish only ./dist and not ./src to npm. On git you do the opposite (track only ./src and not ./dist).

@michielbdejong
Copy link
Contributor Author

We now have 7346f13 which solves part of the problem.

@megoth
Copy link
Contributor

megoth commented Feb 24, 2020

For consistency, remember to add these kinds of changes to all related mashlib/solid-panes projects.

@michielbdejong
Copy link
Contributor Author

Good point! I added an issue to chat-pane. It looks like folder-pane is still in JS, any others you are aware of?

@megoth
Copy link
Contributor

megoth commented Feb 24, 2020

Good point! I added an issue to chat-pane. It looks like folder-pane is still in JS, any others you are aware of?

I guess solid-panes and solid-ui might be the only ones, for now. But have to remember to add them to other projects as we migrate them to TS.

@timea-solid timea-solid deleted the fix-31 branch March 11, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants