Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version breaks solid-panes build #31

Closed
michielbdejong opened this issue Feb 7, 2020 · 3 comments
Closed

Latest version breaks solid-panes build #31

michielbdejong opened this issue Feb 7, 2020 · 3 comments

Comments

@michielbdejong
Copy link
Contributor

The latest version (2.0.5) was distributed unbuilt.

Since this code is now transpiled, the package needs an npm prepublish step. Sorry, I should have added that the package.json as part of adding the transpilation. Will fix in 2.0.6, as a workaround for the time being, to allow solid-panes development to continue, solid-panes can require version 2.0.0 until meeting-pane@2.0.6 becomes available.

michielbdejong added a commit to SolidOS/solid-panes that referenced this issue Feb 7, 2020
michielbdejong added a commit to SolidOS/solid-panes that referenced this issue Feb 7, 2020
michielbdejong added a commit to SolidOS/solid-panes that referenced this issue Feb 7, 2020
@michielbdejong
Copy link
Contributor Author

I think this is now fixed, testing in SolidOS/solid-panes#224

@megoth
Copy link
Contributor

megoth commented Feb 24, 2020

Have you verified the fix, and can this issue be closed?

@michielbdejong
Copy link
Contributor Author

Yep! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants