This repository has been archived by the owner on Oct 16, 2018. It is now read-only.
Merge develop on to master #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adding dagger set up for networking and applicaiton for a more tidy way of arranging dependencies and scoping
- Base unit tests for parsing json responses
- Base json test re-work - Firebase analytics
- AuthPreference to handle storage of user token - Updating unit test arch to utliise the application component for dependency delivery/mocking
- Text utils class added to replicate common android text operations for easier mocking/testing
- Separating each request in to distinct calls rather than handling query params - Okhttp interceptor will now add the user token if there's one present in AuthPreference
- Adding sample error responses for further testing
- Error response object for deserialization
- Base View and Presenter contracts and classes added - WIP login presenter and main activity presenter
- Base View and Presenter contracts and classes added - WIP login presenter and main activity presenter
…thayathil/SEDaily-Android into feature/base_mvp_foundations
- Adding preliminary tests for login presenter
…nfiguration changes. (Derived from https://github.com/Syex/mvp_with_dagger)
…vity - Using lifecycle-aware the android ViewModel class to handle presenter lifetimes during configuration changes - Creating a base dialogfragment class to handle the common MVP features (to be replicated for fragments/activities) - Adding SDE logo - Library updates
- Attempting to standardise syncronised tests for rx operations - Adding android codstyle
…a separate class) - Toast message for showing http error messages - Fixing single-threaded rule for rx tests
- Updates to view binding order for dialog fragment
Current media ID wasn't being set after playing a podcast.
WIP: Add README
…lass Removing redundant application class and migrating to SDEApp
Update .gitignore to be much more comprehensive.
Fix play button not properly pausing.
Add debug build
…sioning_as_property Separating dependency versions for easier management.
* Fixed some butterknife issues * Renabled login button on error
* Updated package name * Replaced to ?attr/actionBarSize * Made links clickable * Added open source info
* - Analytics facade to encapsulate Firebase analytics events * - Updating up/down vote actions to return a completable since we're not expecting a response - Adding tests for Analytics facade usage
* Added some leak checks * Added new launcher icons * Fixed icon alignment * Add tab icons
* - Updating gradle plugin to release version - Ignoring generated files * - Target SDK now 26 - Version bumps in architecture components * - Adding google services version bump
* Added remove download * Added notification progress * Removed title from detail view * Made downloading reactive
* Added initial travis * Remove emulator * Fixed gradlew permission * Updated travis * Fixed indent * Fixed indent * Removed extra tools * Updated build tools * Revered gradle build * Added license * - Adding stubbed google-services.json file to fulfill requirement for travis (#62)
* - Architecture components version bump - Updating dependency configurations to the new gradle api - https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration.html#new_configurations * Updated to Java target version 8
* - Adding kotlin dependencies for both main and testing * - Adding kotlin annotation processor - Updating compile options to target Java 8 * - Architecture components version bump - Updating dependency configurations to the new gradle api - https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration.html#new_configurations * Updated to Java target version 8
* Added skeleton loading and fixed null checks * Added null mp3 check * Added travis * Updated media notification * Fixed is download check * Style updates * Added crashlytics * Added controller null check * Updated speed lifecycle * Added catch and log for small supported speed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.