This repository has been archived by the owner on Oct 16, 2018. It is now read-only.
Added skeleton loading and fixed null checks #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheHollidayInn
added a commit
that referenced
this pull request
Nov 24, 2017
* - Removed unused RetrofitClient - Adding dagger set up for networking and applicaiton for a more tidy way of arranging dependencies and scoping * - Clean up whitespace in network module * - Creating a separate Episode post network service * - Adding autovalue and gson type adapters for deserialisation - Base unit tests for parsing json responses * - Adding new AuthNetworkService for handling authentication requests - Base json test re-work - Firebase analytics * - Adding AuthNetworkService to network module * - Basepreference with common operations implemented - AuthPreference to handle storage of user token - Updating unit test arch to utliise the application component for dependency delivery/mocking * - Adding test for getting a token from shared prefs * - Added convenience check for user logged in - Text utils class added to replicate common android text operations for easier mocking/testing * - Updated post response with upvote/downvote fields * - Implementing post item and mapper between response and post item * - PostRepository implementation for fetching posts - Separating each request in to distinct calls rather than handling query params - Okhttp interceptor will now add the user token if there's one present in AuthPreference * - User repo implemented to perform login and registration operations - Adding sample error responses for further testing * - Adding a login check to user repository - Error response object for deserialization * - Adding presentation package containing the components for MVP - Base View and Presenter contracts and classes added - WIP login presenter and main activity presenter * - Adding presentation package containing the components for MVP - Base View and Presenter contracts and classes added - WIP login presenter and main activity presenter * - Added BasePresenterUnitTest to be extended for any presenter testing - Adding preliminary tests for login presenter * - Adding a PresenterCache to persist presenters for events such as configuration changes. (Derived from https://github.com/Syex/mvp_with_dagger) * - Updating login/registration as a dialog rather than a separate activity - Using lifecycle-aware the android ViewModel class to handle presenter lifetimes during configuration changes - Creating a base dialogfragment class to handle the common MVP features (to be replicated for fragments/activities) - Adding SDE logo - Library updates * - Updating field validation for login and registration - Attempting to standardise syncronised tests for rx operations - Adding android codstyle * - Adding prototype handling for http errors (will need to extract as a separate class) - Toast message for showing http error messages - Fixing single-threaded rule for rx tests * - Enabling login toggle once registration flow finishes. * - More tests for login/registration * - Base Fragment and Base Activity classes added - Updates to view binding order for dialog fragment * - Resetting login/registration invocation to default for now. * Added square android lint and fixed accessibility errors * Fixed many lint errors * Fixed spelling * More spelling * Added final * Added playback control * Added initial download task * fixed git ignore * fixed git * Added file play * Create README.md Update README.md * - Removed duplicate string values * Added initial page load back * - Removing redundant application class and migrating to SDEApp * - Moving LeakCanary initialisation to start before the rest of the other steps * Update .gitignore to be much more comprehensive. * Fix play button not properly pausing. Current media ID wasn't being set after playing a podcast. * Rename variable to be more descriptive * Added debug build fto separate compile name * - Separating dependency versions for easier managment. * Fix merge conflicts. (#30) * Login toggle fix (#49) * Fixed some butterknife issues * Renabled login button on error * Various small fixes (#50) * Updated package name * Replaced to ?attr/actionBarSize * Made links clickable * Added open source info * Analytics Facade (#44) * - Analytics facade to encapsulate Firebase analytics events * - Updating up/down vote actions to return a completable since we're not expecting a response - Adding tests for Analytics facade usage * Create issue_template.md * Various fixes (#56) * Added some leak checks * Added new launcher icons * Fixed icon alignment * Add tab icons * Feature/android studio 3.0 update (#51) * - Updating gradle plugin to release version - Ignoring generated files * - Target SDK now 26 - Version bumps in architecture components * - Adding google services version bump * Download notifications (#57) * Added remove download * Added notification progress * Removed title from detail view * Made downloading reactive * Added speed increase (#60) * added license * Fix the rendering of a podcast detail (#64) (#68) Use a WebView instead of a TextView for rendering the podcast information. * Travis (#70) * Added initial travis * Remove emulator * Fixed gradlew permission * Updated travis * Fixed indent * Fixed indent * Removed extra tools * Updated build tools * Revered gradle build * Added license * - Adding stubbed google-services.json file to fulfill requirement for travis (#62) * Adding build status badge to develop branch * - Architecture components version bump & gradle api update (#65) * - Architecture components version bump - Updating dependency configurations to the new gradle api - https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration.html#new_configurations * Updated to Java target version 8 * Feature/kotlin support (#61) * - Adding kotlin dependencies for both main and testing * - Adding kotlin annotation processor - Updating compile options to target Java 8 * - Architecture components version bump - Updating dependency configurations to the new gradle api - https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration.html#new_configurations * Updated to Java target version 8 * Added skeleton loading and fixed null checks (#66) * Added skeleton loading and fixed null checks * Added null mp3 check * Added travis * Updated media notification * Fixed is download check * Style updates * Added crashlytics * Added controller null check * Updated speed lifecycle * Added catch and log for small supported speed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63
Fixes #52