Port Emboss & SVG gizmo from PrusaSlicer #2819

Noisyfox · 2023-11-21T09:10:44Z

This PR ported the Emboss & SVG gizmo from PrusaSlicer.

Port Emboss gizmo
Port SVG gizmo
Use Orca color scheme for gizmo dialog
~~Support reading text info from old 3mf format~~ Very unlikely: Port Emboss & SVG gizmo from PrusaSlicer #2819 (comment)
LOTS OF TESTING

Fix #1801
Fix #2487
Fix #2523
Fix #2616

(cherry picked from commit prusa3d/PrusaSlicer@057232a)

(cherry picked from commit prusa3d/PrusaSlicer@1bf9dee)

discip · 2023-11-21T09:28:43Z

AMAZING! 😃👍

Thank you so much!

Be sure to let me know if you need help testing.
Regardless, I will do testing, but if there are specific scenarios that need testing, I'm happy to help.

Noisyfox · 2023-11-21T10:52:48Z

AMAZING! 😃👍

Thank you so much!

Be sure to let me know if you need help testing. Regardless, I will do testing, but if there are specific scenarios that need testing, I'm happy to help.

Just use it normally and do whatever you usually do and see if any existing things are broken/changed. Thanks for your testing~

Eldenroot · 2023-11-21T13:59:30Z

Perfection! Thank you, fingers crossed

Eldenroot · 2023-11-21T21:12:22Z

Just one note - is possible (and it bothers me in Prusa Slicer / Bambu studio) - when you select the text, make the selected text in a different color? Now it is not easy to see sometime in the model... thank you

Noisyfox · 2023-11-22T00:43:04Z

Just one note - is possible (and it bothers me in Prusa Slicer / Bambu studio) - when you select the text, make the selected text in a different color? Now it is not easy to see sometime in the model... thank you

Good idea, will try doing that.

discip · 2023-11-22T13:56:42Z

@Noisyfox

Just wanted to thank you for your dedication and all the effort you put into OrcaSlicer. 😃👍❤️

Unfortunately, these days many people take such an attitude for granted.
But I know how rewarding it can be when someone lets you know their appreciation. Even if it’s just a "thank you".
Hope this keeps your mood up.

SoftFever · 2023-11-22T15:28:13Z

Bravo!

discip · 2023-11-22T20:06:52Z

I don't know if this is already being worked on, but there are some differences in the dialog-UI:

OrcaSlicer	PrusaSlicer

discip · 2023-11-22T20:44:19Z

May I ask what the purpose of this in your screenshot is?

Noisyfox · 2023-11-23T00:59:25Z

I don't know if this is already being worked on, but there are some differences in the dialog-UI:

OrcaSlicer PrusaSlicer

Yeah this is a known issue, some of the special icons haven't been ported over yet.

May I ask what the purpose of this in your screenshot is?

Good question, I didn't add this option, it must be there but just been hidden under certain conditions.

cpasoft · 2023-11-23T12:26:14Z

Love it... Download and testing...

Noisyfox · 2023-11-23T13:03:36Z

Update: It will be very unlikely that we are able to port the emboss tool while keeping compatibility with existing Orca/BBS 3mf file. Any existing texts will be converted to normal mesh object once opened using this build (but the file will not be modified unless you save it with the new build), means you can still slicing the file, move/rotate/scale/delete the text object (i.e., anything that you can do to a normal mesh object), but will no longer able to edit the text such as change text content, change font etc.

Same goes to the other way, project that has text (and SVG) added using this build can still be opened by BBS/old Orca, but the texts and svgs will be treated as normal object.

discip · 2023-11-23T13:27:22Z

So it means that projects created with current Orca will lose the text (convert to mesh), but projects created with the implementation from this PR and onwards will be able to store text (not convert to mesh).

Right?

Noisyfox · 2023-11-23T14:32:31Z

So it means that projects created with current Orca will lose the text (convert to mesh), but projects created with the implementation from this PR and onwards will be able to store text (not convert to mesh).

Right?

Yes

discip · 2023-12-07T09:06:56Z

@Noisyfox
Sorry, but unfortunately there are still some little issues:

1. Rotation of the main object

As long as the main object is not rotated everything works as expected, but as soon as you rotate it, the text rotation will be changed. But you won't notice until you save the project, open it again and try to manipulate the text either by clicking the text after the text gizmo was selected or by changing any value.

2. Expansion of text gizmo card after 'Advanced' is clicked

The text gizmo card only expands after the mouse gets moved.
And some times only clicking the arrow makes it unfold (not reaction if the word 'Advanced' is clicked).

Thank you for your patience! Highly appreciated! 👍

SoftFever · 2023-12-07T12:03:48Z

Shall we change the font color to black? It's barely visible
It list item looks a bit too big too, what do you think@@

Noisyfox · 2023-12-07T14:41:22Z

As long as the main object is not rotated everything works as expected, but as soon as you rotate it, the text rotation will be changed. But you won't notice until you save the project, open it again and try to manipulate the text either by clicking the text after the text gizmo was selected or by changing any value.

Should have been fixed now... Finger crossed.

Noisyfox · 2023-12-07T14:57:26Z

Noticed another issue... The from surface is wrong after saving & opening.

discip · 2023-12-07T19:50:45Z

I'm sorry, but there is still something not right.

The previous distortion/rotation issue is gone and replaced by this movement in Y direction.

Noisyfox · 2023-12-08T01:59:34Z

I'm sorry, but there is still something not right.

The previous distortion/rotation issue is gone and replaced by this movement in Y direction.

How could I reproduce this issue?

discip · 2023-12-08T06:50:20Z

How could I reproduce this issue?

Create new project
Add primitive > cube
Place text on it
Save project
Open saved project
Select text
Open text gizmo
Click text (on the cube) or change any value
Notice how the text on the object moves

Noisyfox · 2023-12-08T08:55:12Z

Noticed another issue... The from surface is wrong after saving & opening.

PS has the same issue though... And I found the current algorithm is in a situation that this cannot be fixed properly. I've already spent too much time on this issue so far and just won't be able to do anything to it. I'll just ignore this for now and see what PS will come up with.

I've also reported this to Prusa: prusa3d/PrusaSlicer#11868

Noisyfox · 2023-12-08T09:00:43Z

How could I reproduce this issue?

Create new project

Add primitive > cube

Place text on it

Save project

Open saved project

Select text

Open text gizmo

Click text (on the cube) or change any value

Notice how the text on the object moves

This should have been solved now, though you'll have to recreate the project or re-add text, because the previously saved file is broken.

# Conflicts: # src/slic3r/GUI/Plater.cpp

Noisyfox · 2023-12-08T14:41:00Z

Shall we change the font color to black? It's barely visible It list item looks a bit too big too, what do you think@@

Updated.

discip · 2023-12-08T23:07:21Z

Thank you very much! Finally solved! 😃👍🏻❤️

# Conflicts: # src/slic3r/GUI/GLCanvas3D.cpp

SoftFever · 2023-12-09T14:18:44Z

@Noisyfox I did some preliminary tests, and it looks good! Do you have any other fixes planned for this PR?

Noisyfox · 2023-12-09T14:40:45Z

@Noisyfox I did some preliminary tests, and it looks good! Do you have any other fixes planned for this PR?

No at the moment.

SoftFever

Looks good

SoftFever · 2023-12-09T14:45:48Z

@Noisyfox I did some preliminary tests, and it looks good! Do you have any other fixes planned for this PR?

No at the moment.

Cool, I'm merge it now.
It's driving me crazy to switch deferent version of deps when switching PR...

FillPavS · 2023-12-22T07:41:58Z

@Noisyfox I did some preliminary tests, and it looks good! Do you have any other fixes planned for this PR?

No at the moment.

Cool, I'm merge it now. It's driving me crazy to switch deferent version of deps when switching PR...

Please note this bug caused by this commit. #3171

One of the commits from SoftFever/OrcaSlicer#2819 (933aa3050bf5297b3714fb59575b3ec86e017112) Co-authored-by: Ocraftyone <ocraftyone@users.noreply.github.com>

One of the commits from SoftFever/OrcaSlicer#2819 (933aa3050bf5297b3714fb59575b3ec86e017112)

tamasmeszaros and others added 10 commits November 20, 2023 19:09

Rework UI jobs to make them more understandable and flexible.

ffba59e

Update Orca specific jobs

9a93e1b

Fix progress issue

1fdb9b1

Fix dark mode and window radius

ad45836

Update cereal version from 1.2.2 to 1.3.0

f85b511

(cherry picked from commit prusa3d/PrusaSlicer@057232a)

Initial port of Emboss gizmo

cff0ffe

Bump up CGAL version to 5.4

cca9984

(cherry picked from commit prusa3d/PrusaSlicer@1bf9dee)

Fix text rotation

e5de2d5

Fix test dragging

2f858db

Add text gizmo to right click menu

84d7aaa

Initial port of SVG gizmo

a60b7e9

Fix text rotation

c21eb15

Fix Linux build

af05b33

Noisyfox force-pushed the dev/gizmo-emboss branch from e92390f to af05b33 Compare November 22, 2023 14:36

Fix "from surface"

425ef3a

Fix -90 rotation

b9fdb6a

Fix emboss rotation

ef8d928

Emboss: Fix advance toggle

d353e2c

Fix text position after reopened the project

a471d16

Noisyfox added 3 commits December 8, 2023 21:56

Merge remote-tracking branch 'remote/main' into dev/gizmo-svg

7ed88ac

# Conflicts: # src/slic3r/GUI/Plater.cpp

Make font style preview darker

b9c06f0

Make font style preview selector height shorter

a34a2e7

Noisyfox added 2 commits December 9, 2023 10:17

Merge branch 'main' into dev/gizmo-emboss

221297e

Merge remote-tracking branch 'remote/main' into dev/gizmo-svg

94c19fd

# Conflicts: # src/slic3r/GUI/GLCanvas3D.cpp

SoftFever approved these changes Dec 9, 2023

View reviewed changes

SoftFever merged commit 933aa30 into SoftFever:main Dec 9, 2023
12 checks passed

This was referenced Dec 17, 2023

Doesn't slice anymore. A fatal error occurred: "Access violation" #3158

Closed

Bambu lab X1C. When sending a print job, progress gets stuck at 10% on some models #3171

Closed

Noisyfox mentioned this pull request Feb 11, 2024

Various Emboss improvements from PS #4039

Merged

Ocraftyone pushed a commit to Ocraftyone/BambuStudio-Ocraftyone that referenced this pull request Sep 7, 2024

Fix progress issue

fb18cd4

One of the commits from SoftFever/OrcaSlicer#2819 (933aa3050bf5297b3714fb59575b3ec86e017112)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port Emboss & SVG gizmo from PrusaSlicer #2819

Port Emboss & SVG gizmo from PrusaSlicer #2819

Noisyfox commented Nov 21, 2023 •

edited

Loading

discip commented Nov 21, 2023 •

edited

Loading

Noisyfox commented Nov 21, 2023

AMAZING! 😃👍

Thank you so much!

Eldenroot commented Nov 21, 2023

Eldenroot commented Nov 21, 2023

Noisyfox commented Nov 22, 2023

discip commented Nov 22, 2023 •

edited

Loading

SoftFever commented Nov 22, 2023

discip commented Nov 22, 2023

discip commented Nov 22, 2023

Noisyfox commented Nov 23, 2023

cpasoft commented Nov 23, 2023

Noisyfox commented Nov 23, 2023

discip commented Nov 23, 2023 •

edited

Loading

Noisyfox commented Nov 23, 2023

discip commented Dec 7, 2023 •

edited

Loading

SoftFever commented Dec 7, 2023 •

edited

Loading

Noisyfox commented Dec 7, 2023

Noisyfox commented Dec 7, 2023

discip commented Dec 7, 2023

Noisyfox commented Dec 8, 2023

discip commented Dec 8, 2023

Noisyfox commented Dec 8, 2023 •

edited

Loading

Noisyfox commented Dec 8, 2023 •

edited

Loading

Noisyfox commented Dec 8, 2023

discip commented Dec 8, 2023

SoftFever commented Dec 9, 2023

Noisyfox commented Dec 9, 2023

SoftFever left a comment

SoftFever commented Dec 9, 2023

FillPavS commented Dec 22, 2023 •

edited

Loading

Port Emboss & SVG gizmo from PrusaSlicer #2819

Port Emboss & SVG gizmo from PrusaSlicer #2819

Conversation

Noisyfox commented Nov 21, 2023 • edited Loading

discip commented Nov 21, 2023 • edited Loading

AMAZING! 😃👍

Thank you so much!

Noisyfox commented Nov 21, 2023

AMAZING! 😃👍

Thank you so much!

Eldenroot commented Nov 21, 2023

Eldenroot commented Nov 21, 2023

Noisyfox commented Nov 22, 2023

discip commented Nov 22, 2023 • edited Loading

Just wanted to thank you for your dedication and all the effort you put into OrcaSlicer. 😃👍❤️

SoftFever commented Nov 22, 2023

discip commented Nov 22, 2023

discip commented Nov 22, 2023

Noisyfox commented Nov 23, 2023

cpasoft commented Nov 23, 2023

Noisyfox commented Nov 23, 2023

discip commented Nov 23, 2023 • edited Loading

Noisyfox commented Nov 23, 2023

discip commented Dec 7, 2023 • edited Loading

1. Rotation of the main object

2. Expansion of text gizmo card after 'Advanced' is clicked

Thank you for your patience! Highly appreciated! 👍

SoftFever commented Dec 7, 2023 • edited Loading

Noisyfox commented Dec 7, 2023

Noisyfox commented Dec 7, 2023

discip commented Dec 7, 2023

Noisyfox commented Dec 8, 2023

discip commented Dec 8, 2023

Noisyfox commented Dec 8, 2023 • edited Loading

Noisyfox commented Dec 8, 2023 • edited Loading

Noisyfox commented Dec 8, 2023

discip commented Dec 8, 2023

Thank you very much! Finally solved! 😃👍🏻❤️

SoftFever commented Dec 9, 2023

Noisyfox commented Dec 9, 2023

SoftFever left a comment

Choose a reason for hiding this comment

SoftFever commented Dec 9, 2023

FillPavS commented Dec 22, 2023 • edited Loading

Noisyfox commented Nov 21, 2023 •

edited

Loading

discip commented Nov 21, 2023 •

edited

Loading

discip commented Nov 22, 2023 •

edited

Loading

discip commented Nov 23, 2023 •

edited

Loading

discip commented Dec 7, 2023 •

edited

Loading

SoftFever commented Dec 7, 2023 •

edited

Loading

Noisyfox commented Dec 8, 2023 •

edited

Loading

Noisyfox commented Dec 8, 2023 •

edited

Loading

FillPavS commented Dec 22, 2023 •

edited

Loading