Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Compiled missing docs #632

Merged
merged 2 commits into from
Aug 3, 2021

Conversation

robbruce
Copy link
Contributor

@robbruce robbruce commented Aug 3, 2021

Docs hadn't been ran for new resources and data sources. This PR adds in the newly generated documents.

@robbruce robbruce requested a review from a team as a code owner August 3, 2021 08:32
@robbruce robbruce requested a review from alldoami August 3, 2021 08:32
@robbruce robbruce changed the title Compiled missing docs fix: Compiled missing docs Aug 3, 2021
@ChrisIsidora
Copy link
Contributor

@robbruce It used to be automated in the pipeline/actions? Is this not the case anymore?

@robbruce
Copy link
Contributor Author

robbruce commented Aug 3, 2021

@robbruce It used to be automated in the pipeline/actions? Is this not the case anymore?

@ChrisIsidora - no idea, I'm not a maintainer, just an active contributor!

@alldoami - some guidance on what you'd like people to do with docs would be great, if people need to build themselves then maybe an extra check should be in place to see if the built docs would differ from whats in the PR?

@alldoami
Copy link
Contributor

alldoami commented Aug 3, 2021

If you run make docs it should update all the docs! Is this what you did?

@alldoami
Copy link
Contributor

alldoami commented Aug 3, 2021

/ok-to-test sha=c044d26

@github-actions
Copy link

github-actions bot commented Aug 3, 2021

Integration tests success for c044d26

@alldoami
Copy link
Contributor

alldoami commented Aug 3, 2021

/ok-to-test sha=bc3586d

@github-actions
Copy link

github-actions bot commented Aug 3, 2021

Integration tests success for bc3586d

@alldoami alldoami merged commit 3fb14cf into Snowflake-Labs:main Aug 3, 2021
@ChrisIsidora ChrisIsidora mentioned this pull request Aug 12, 2021
2 tasks
jtzero pushed a commit to rxrevu/terraform-provider-snowflake that referenced this pull request Aug 19, 2021
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants