Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Procedures #619

Merged
merged 13 commits into from
Aug 12, 2021
Merged

feat: Procedures #619

merged 13 commits into from
Aug 12, 2021

Conversation

funes79
Copy link
Contributor

@funes79 funes79 commented Jul 24, 2021

  • New resource snowflake_procedure
  • As a user using Standard edition of Snowflake, had to add environment variables to prevent the creation of Materialized views and Masking policies.

Test Plan

  • acceptance tests
  • unit tests

References

@funes79 funes79 requested a review from a team as a code owner July 24, 2021 17:40
@funes79 funes79 requested a review from alldoami July 24, 2021 17:40
@funes79 funes79 changed the title Procedures feat Procedures Jul 24, 2021
@funes79 funes79 changed the title feat Procedures feat: Procedures Jul 24, 2021
@alldoami
Copy link
Contributor

/ok-to-test sha=6b08ca9

@github-actions
Copy link

Integration tests success for 6b08ca9

@ChrisIsidora
Copy link
Contributor

@funes79 Can you take a look at the comments of @alldoami so this can be merged? I have a dependency on this feature. Thanks in advance

@ChrisIsidora
Copy link
Contributor

@funes79 Can you also run the make docs so that the .md (markdown) is created? (optionally an example tf in the example folder could be nice) Thanks in advance

@funes79
Copy link
Contributor Author

funes79 commented Aug 5, 2021

@ChrisIsidora docs and examples added.

@funes79
Copy link
Contributor Author

funes79 commented Aug 9, 2021

@alldoami is it ok to merge?

@funes79 funes79 requested a review from alldoami August 10, 2021 08:24
@alldoami
Copy link
Contributor

/ok-to-test sha=a736b4d

@alldoami
Copy link
Contributor

If you run make docs do you get a diff?

@github-actions
Copy link

Integration tests failure for a736b4d

@ChrisIsidora
Copy link
Contributor

@alldoami Added SKIP_SCIM_INTEGRATION_TESTS in #635 to fix the SCIM integration issue as it doesn't clean up properly if another test previously fails at some point or if Integrations tests are ran in parallel for different PRs.

@ChrisIsidora
Copy link
Contributor

If you run make docs do you get a diff?

@alldoami I think @funes79 needs to remove the new docs for the procedure. But after merge there needs to be a new PR created after running make docs because the new docs for resources/datasources are not automatically created after commit.

@funes79
Copy link
Contributor Author

funes79 commented Aug 12, 2021

I do not understand. On my local make docs runs fine. But I see that it failed in the Github actions. Is the any info why it causing the failure?

@funes79
Copy link
Contributor Author

funes79 commented Aug 12, 2021

If you run make docs do you get a diff?

Yes I got a diff, so now I pushed a new commit to update the docs for procedure.

@ChrisIsidora
Copy link
Contributor

I do not understand. On my local make docs runs fine. But I see that it failed in the Github actions. Is the any info why it causing the failure?

@funes79 I don't know exactly why but I had similar issues some time ago when I also introduced a new resources. I suspect that the make docs checks against the main branch and compares the docs in the PR branch and if the comparison yields a difference then it fails, but in this case for new resources it's logical that there is a difference because the resource is not there yet in the main branch. So I think the use case for the make docs check is primarily for flagging existing resources docs that needs to be updated if that resource was changed in the PR branch.

So fastest solution for now is to remove the new .md and after the merge, open a PR with only the new .md.

(Related to #632)

@alldoami
Copy link
Contributor

/ok-to-test sha=40aca4d

@github-actions
Copy link

Integration tests success for 40aca4d

@alldoami alldoami merged commit 869ff75 into Snowflake-Labs:main Aug 12, 2021
jtzero pushed a commit to rxrevu/terraform-provider-snowflake that referenced this pull request Aug 19, 2021
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants