fix: Warehouse create and alter properties #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edulop91
reviewed
Jul 7, 2021
| @@ -11,12 +11,13 @@ import ( | |||
| ) | |||
|
|
|||
| // warehouseCreateProperties are only available via the CREATE statement | |||
| var warehouseCreateProperties = []string{"initially_suspended", "wait_for_provisioning", "statement_timeout_in_seconds"} | |||
| var warehouseCreateProperties = []string{"initially_suspended", "wait_for_provisioning"} | |||
edulop91
reviewed
Jul 7, 2021
| @@ -103,6 +104,20 @@ var warehouseSchema = map[string]*schema.Schema{ | |||
| ForceNew: false, | |||
| Description: "Specifies the time, in seconds, after which a running SQL statement (query, DDL, DML, etc.) is canceled by the system", | |||
| }, | |||
| "statement_queued_timeout_in_seconds": { | |||
|
Integration tests failure for 89edc5af14d2552b63930f3f3d1c9a67e3046350 |
|
Integration tests failure for 442f08ff98097275ede2681dee7fb8f887abd2e3 |
|
Integration tests failure for 634a24f375aa07b0c6e647ad693ce7d2d5170117 |
|
Integration tests success for b1ea85ddc1d4fc95dcb10c71596cc59a370f7fd0 |
edulop91
approved these changes
Jul 8, 2021
jtzero
pushed a commit
to rxrevu/terraform-provider-snowflake
that referenced
this pull request
Aug 19, 2021
anton-chekanov
pushed a commit
to anton-chekanov/terraform-provider-snowflake
that referenced
this pull request
Jan 25, 2022
daniepett
pushed a commit
to daniepett/terraform-provider-snowflake
that referenced
this pull request
Feb 9, 2022
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing: #583
Adding optional parameters to list of properties. Already had
statement_timeout_in_secondsbut added the other two parameters (which are available in both create and alter).Test Plan
References