Support Parameters within providers for Warehouse and Account

[alanmcruickshank]

Is your feature request related to a problem? Please describe.

We currently don't have the statement timeout or date configuration parameters configured anywhere as code, this means that they're had to version control and therefore control sensibly.

Descriptions of the parameters available for configuration are here: https://docs.snowflake.com/en/sql-reference/parameters.html

Parameters can be assigned to the account, the session or to an object. For terraform, assigning parameters to the session is somewhat meaningless. Account parameters would be useful (for our use case, namely TIMESTAMP_INPUT_FORMAT, TIMESTAMP_OUTPUT_FORMAT, TIMEZONE, WEEK_START, LOCK_TIMEOUT, STATEMENT_QUEUED_TIMEOUT_IN_SECONDS, STATEMENT_TIMEOUT_IN_SECONDS) & object parameters on warehouses would be useful (namely STATEMENT_QUEUED_TIMEOUT_IN_SECONDS, STATEMENT_TIMEOUT_IN_SECONDS).

The only meaningful parameter on a user is NETWORK_POLICY and that is already handled with the existing snowflake_network_policy_attachment resource.

Describe the solution you'd like

• Ideally the snowflake_warehouse resource would accept either a mapping of parameter values or the timeout parameters directly on the resource.
• Ideally there would be a new resource called snowflake_account_parameter which would allow the setting of parameters on the account.

Describe alternatives you've considered

For warehouse parameters, the choice between a mapping of parameters or "top level" configuration values for timeouts are of equal ease for the user. The latter is tidier albeit less flexible:

resource snowflake_warehouse w {
  name           = "test"
  comment        = "foo"
  warehouse_size = "small"
  statement_timeout_in_seconds = 1200
  statement_queued_timeout_in_seconds = 600
}

For setting account parameters, we could introduce a snowflake_account resource and set the parameters within that, we could make individual resources specifically for each potential parameter or we could have a generic snowflake_account_parameter object to set one or more parameters on the account. The latter feels tidiest, although that's mostly from a user experience point of view and there may be other reasons for choosing one of the other options.

[alanmcruickshank]

Looking at warehouse.go, I can see that statement_timeout_in_seconds is already implemented, but statement_queued_timeout_in_seconds is not. It also seems that statement_timeout_in_seconds is only available on create and not on update.

I assume this was because those keywords were supported on CREATE WAREHOUSE (https://docs.snowflake.com/en/sql-reference/sql/create-warehouse.html), and not on ALTER WAREHOUSE, but I can see that both are supported on both commands (https://docs.snowflake.com/en/sql-reference/sql/alter-warehouse.html).

Would it be sufficient to just remove this filter which means that not all of the fields are passed to the update statement?

[alldoami]

Just merged a fix! Let me know if that addresses your issue @alanmcruickshank!

[alanmcruickshank]

Thanks @alldoami - That covers off everything against the warehouse! 🎉 😄

I think there's still value in the account level parameters too however, which I realize also don't have an obvious place to add at the moment. Do you know how we might add them too?

[alldoami]

We'd probably have to create a new resource I'm guessing...

[tabletcorry]

Looks like there are other meaningful parameters available for users, such as TIMEZONE, that are impossible to set with the current resource? Seems like it could be added akin to the PR above, but wanted to check first 😄

[sfc-gh-asawicki]

We are closing this issue as part of a cleanup described in announcement. If you believe that the issue is still valid in v0.89.0, please open a new ticket.