Authorizing fields to have child nodes, and fix their parsing in the … #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…converter to proper snake case.
Closed
This was referenced Mar 22, 2017
This was referenced Apr 2, 2017
This was referenced Aug 1, 2018
botisSmile
pushed a commit
to botisSmile/elasticsuite
that referenced
this pull request
Sep 8, 2021
peterjaap
added a commit
to peterjaap/elasticsuite
that referenced
this pull request
Apr 15, 2022
When no category URL suffix is defined, the get function returns NULL causing this error: Deprecated Functionality: str_replace(): Passing null to parameter Smile-SA#1 ($search) of type array|string is deprecated
vsushkov
added a commit
to vsushkov/elasticsuite
that referenced
this pull request
Apr 21, 2022
Sometimes one of the `$optionTextValues` could be `null`. And in PHP 8 `Passing null to parameter Smile-SA#1 ($string) of type string is deprecated`. So I suggest to explicitly cast all values to string.
vsushkov
added a commit
to vsushkov/elasticsuite
that referenced
this pull request
Apr 21, 2022
Sometimes one of the `$optionTextValues` could be `null`. And in PHP 8 `Passing null to parameter Smile-SA#1 ($string) of type string is deprecated`. So I suggest to explicitly cast all values to string.
ghost
mentioned this pull request
ecrocombe
pushed a commit
to ecrocombe/elasticsuite
that referenced
this pull request
Sep 12, 2023
rbayet
pushed a commit
to ecrocombe/elasticsuite
that referenced
this pull request
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…converter to proper snake case.