Reverted intentional bugs and removed popup notifcation #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,7 +21,6 @@ export class ErrorBoundary extends React.Component { | |||
| componentDidCatch(error, errorInfo) { | |||
| // You can also log the error to an error reporting service | |||
| // logErrorToMyService(error, errorInfo); | |||
| store.dispatch(setErrorPopupMessage('An error occured. Please try again')); | |||
There was a problem hiding this comment.
Should we be keeping it, or not? 🤔
What's your points for removing it?
There was a problem hiding this comment.
I figured it wasn't needed since we were redirecting to the 404 page anyway. It was also never showing up when I tested it, so that'll take some debugging. Do you think we should keep it?
|
Yes, then we should definitely remove it. If something is not getting used,
it’s dead code,better be removed.
…On Wed, 14 Apr 2021 at 10:57 PM, Nithin ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In simplq/src/components/ErrorHandler.jsx
<#605 (comment)>
:
> @@ -23,7 +21,6 @@ export class ErrorBoundary extends React.Component {
componentDidCatch(error, errorInfo) {
// You can also log the error to an error reporting service
// logErrorToMyService(error, errorInfo);
- store.dispatch(setErrorPopupMessage('An error occured. Please try again'));
I figured it wasn't needed since we were redirecting to the 404 page
anyway. It was also never showing up when I tested it, so that'll take some
debugging. Do you think we should keep it?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#605 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACV4EOCHB2RMKYDRN5SIK5LTIXGBRANCNFSM4223FUZA>
.
|
daltonfury42
approved these changes
Apr 14, 2021
maaverik
added a commit
that referenced
this pull request
Apr 17, 2021
* Remove amplify backend (#524) * Async actions for Queue Status and My Queues API calls (#522) * Add gitter chat badge (#530) * Pick api base url from config. (#525) * Remove unused backend env amplify (#532) * Add LoadingStatus Component (#531) * Add LoadingStatus Component Upgrade storybook to 6.1.17 Fix LoadingIndicator stories * Pause resume queue (#586) * Merge fixes after pause queue (#598) * Add plus prefix to phone number, rename onClick to onSubmit (#600) * Fix Sonarqube code smells and lint errors (#599) * Fix Sonarqube code smells and lint errors * Address review comments - revert direct return and eslintrc * Some minor changes to add A2HS (#602) * Added size property to the icons & shortened name * file name changed * a square 144x144px icon of the logo * register the service worker to enable pwa * Modified phone icon on footer and ErrorHandler (#604) * Removed phone icon with outdated link * Added optional chaining in PageNotFound * Fix return home button when reaching from errorHandler * Intentional bug to check sentry logging * Customized sentry logs * Still experimenting with sentry * Trying another approach * Reverted intentional bugs and removed popup notifcation (#605) * Reverted intentional bugs and removed popup notifcation * Fix code style issues with ESLint * Make Contact Us on Navbar bit more bold to stand out (#609)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentry seems to work fine. The errors don't get logged in the dashboard because we exceeded our quota. (ref: "If you’ve exceeded your quota threshold, the server will respond with a 429 HTTP status code.")
