Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor changes to add A2HS #602

Merged
merged 4 commits into from
Apr 1, 2021
Merged

Some minor changes to add A2HS #602

merged 4 commits into from
Apr 1, 2021

Conversation

shiv15
Copy link
Contributor

@shiv15 shiv15 commented Apr 1, 2021

Only minor changes to add A2HS. Added 144x144px icon. Shortened the name as the one before was going out of the screen. Added sizes property for the icon in manifest.json.

@daltonfury42 daltonfury42 linked an issue Apr 1, 2021 that may be closed by this pull request
Copy link
Collaborator

@daltonfury42 daltonfury42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Copy link
Collaborator

@maaverik maaverik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@maaverik maaverik merged commit 7754274 into SimplQ:master Apr 1, 2021
maaverik added a commit that referenced this pull request Apr 17, 2021
* Remove amplify backend (#524)

* Async actions for Queue Status and My Queues API calls (#522)

* Add gitter chat badge (#530)

* Pick api base url from config. (#525)

* Remove unused backend env amplify (#532)

* Add LoadingStatus Component (#531)

* Add LoadingStatus Component

Upgrade storybook to 6.1.17

Fix LoadingIndicator stories

* Pause resume queue (#586)

* Merge fixes after pause queue (#598)

* Add plus prefix to phone number, rename onClick to onSubmit (#600)

* Fix Sonarqube code smells and lint errors (#599)

* Fix Sonarqube code smells and lint errors

* Address review comments - revert direct return and eslintrc

* Some minor changes to add A2HS (#602)

* Added size property to the icons & shortened name

* file name changed

* a square 144x144px icon of the logo

* register the service worker to enable pwa

* Modified phone icon on footer and ErrorHandler (#604)

* Removed phone icon with outdated link

* Added optional chaining in PageNotFound

* Fix return home button when reaching from errorHandler

* Intentional bug to check sentry logging

* Customized sentry logs

* Still experimenting with sentry

* Trying another approach

* Reverted intentional bugs and removed popup notifcation  (#605)

* Reverted intentional bugs and removed popup notifcation

* Fix code style issues with ESLint

* Make Contact Us on Navbar bit more bold to stand out (#609)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement PWA A2HS functionality
3 participants