Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flowmeter #197

Closed
wants to merge 24 commits into from
Closed

Flowmeter #197

wants to merge 24 commits into from

Conversation

AntonioT7
Copy link
Contributor

@leloup314
Copy link
Member

Nice, to link an issue on basil, simply put the pound sign and the corresponding issue number e.g. #83

@AntonioT7
Copy link
Contributor Author

#83

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -2.57 ⚠️

Comparison is base (26fcc9f) 35.90% compared to head (acd5d13) 33.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
- Coverage   35.90%   33.33%   -2.57%     
==========================================
  Files          79       84       +5     
  Lines        5284     5691     +407     
==========================================
  Hits         1897     1897              
- Misses       3387     3794     +407     
Impacted Files Coverage Δ
basil/HL/bronkhorst_elflow.py 0.00% <0.00%> (ø)
basil/HL/julaboFP50.py 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@YannickDieter
Copy link
Contributor

@matthias-schuessler I guess this is needed for our module qc. Can you please check so that we can merge that too?

@YannickDieter
Copy link
Contributor

Closed in favor of #220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants