Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging for bronkhorst_elflow instead of pring #83

Closed
themperek opened this issue May 13, 2018 · 3 comments
Closed

Logging for bronkhorst_elflow instead of pring #83

themperek opened this issue May 13, 2018 · 3 comments

Comments

@themperek
Copy link
Member

@thirono Could you change print to logger here:
https://github.com/SiLab-Bonn/basil/blob/development/basil/HL/bronkhorst_elflow.py

Example: https://github.com/SiLab-Bonn/basil/blob/development/basil/HL/NTCRegister.py

+ format the source

@DavidLP
Copy link
Collaborator

DavidLP commented May 14, 2018

Also I recommend to put a link to the protocol description and/or a few lines about the protocol. See for example how it is done in basil for other hardware here or here.

@leloup314
Copy link
Member

@AntonioT7 you could solve this issue in your fork, would be good chance to practice ;)

@cbespin
Copy link
Contributor

cbespin commented May 28, 2024

I am closing this as I do not see any print statements in the module anymore (whenever they got fixed).

@cbespin cbespin closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants