Compute class and module hierarchy #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
KaanOzkan
approved these changes
Jun 19, 2024
|
|
||
| assert_equal( | ||
| ["B", "C"], | ||
| model.subtypes(model["A"]).map(&:full_name).sort, |
There was a problem hiding this comment.
Should we not test the order? Why do we sort?
There was a problem hiding this comment.
Good question: The order is not relevant at this point since we do not do any kind of linearization (yet).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have a complete model (#557) and a poset (#558) we can compute the full class/module hierarchy.
This will allow deadcode plugins to reason about the whole ancestor chain rather than just the parent class.