Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Model building #557

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Introduce Model building #557

merged 3 commits into from
Jun 18, 2024

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Jun 17, 2024

While we're working on making the RubyIndexer a standalone gem, we can start making room for it in Spoom so we can base the dead code analysis.

In this PR we create a representation close to what the RubyIndexer builds so we'll be able to use it in dead code analysis in subsequent PRs.

This will allow us to test the concepts and see what's missing to the RubyIndexer API to build other tools than an LSP server.

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar added the chore Chore task label Jun 17, 2024
@Morriar Morriar requested a review from vinistock June 17, 2024 20:34
@Morriar Morriar self-assigned this Jun 17, 2024
@Morriar Morriar requested a review from a team as a code owner June 17, 2024 20:34
@Morriar Morriar requested a review from egiurleo June 17, 2024 20:34
lib/spoom/model.rb Show resolved Hide resolved
lib/spoom/model/builder.rb Show resolved Hide resolved
lib/spoom/model/builder.rb Show resolved Hide resolved
lib/spoom/model/builder.rb Show resolved Hide resolved
lib/spoom/model/namespace_visitor.rb Outdated Show resolved Hide resolved
Morriar added 2 commits June 18, 2024 12:19
An abstract Visitor implementation that keeps track of the traversed
namespaces.

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar force-pushed the at-model-builder branch from 0ee72b9 to a6cad31 Compare June 18, 2024 16:21
@Morriar Morriar requested a review from vinistock June 18, 2024 16:24
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so excited to get Spoom on the indexer. It's the culmination of a lot of work!

@Morriar Morriar merged commit 8458894 into main Jun 18, 2024
8 checks passed
@Morriar Morriar deleted the at-model-builder branch June 18, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants