Make EnsureAuthenticatedLinks compatible with AppBridge 2

[kirillplatonov]

What this PR does

EnsureAuthenticatedLinks is currently broken and doesn't pass host header for AppBridge 2. As a result, all deep links in the app are broken.

I added the missing "host" header to redirect to the splash page to fix it.

Checklist

Before submitting the PR, please consider if any of the following are needed:

• Update CHANGELOG.md if the changes would impact users
• Update README.md, if appropriate.
• Update any relevant pages in /docs, if necessary
• For security fixes, the Disclosure Policy must be followed.

[rs-ehyde]

We are trying to get our application listed and we were just told that AppBridge 2.0 is a requirement. Pretty wild that this is still broken.

[kirillplatonov]

@NabeelAhsen @rezaansyed @andyw8
Hey. App Bridge 2.0 is a hard requirement for new app submissions. Any chance this bugfix can be merged?

[artyrcheek]

We are trying to get our application listed and we were just told that AppBridge 2.0 is a requirement. Pretty wild that this is still broken.

Crazy this still isnt fixed

[sshaw]

We are trying to get our application listed and we were just told that AppBridge 2.0 is a requirement. Pretty wild that this is still broken.

This is why I avoid embedded apps. Too many headaches!

[kirillplatonov]

@BranLiang I saw you merged another PR in this repo recently. Could you please review this one too?

[NabeelAhsen]

Hey it's been a while since I actively contributed to this gem. It seems that this PR keeps slipping through the cracks, I can help ship + release this change.

I'm approving this to unblock - but let's get this PR up to speed with the main branch and add some more test coverage in the event where host isn't specified as a param by Shopify.

[kirillplatonov]

@NabeelAhsen Hey and Happy new year!
Thanks for taking the time and looking at this 🙏. I rebased PR from master and simplified changes a bit.

We have a few more PR's that needs some attention to fully support AppBridge 2, improve JWT integration, and make the engine compatible with Ruby 3 and Rails 7. We're using this fork for these changes but it would be awesome to move these changes to the official repo. If you don't mind I will update them and mention you so we could merge & ship the new release.

[NabeelAhsen]

@kirillplatonov are the changes in this PR the only critical changes you've found to get this gem AppBridge 2.0 compatible for multi-pages apps?

If not, could you link to the other PRs here as well? I'd like to prioritize shipping them and getting them released as the next minor version.

[mjesar]

Hi
I have upgraded shopify_app gem to (18.0.3) because getting this error [ShopifyApp::EnsureAuthenticatedLinks] Redirecting to login: [ShopifyApp::LoginProtection::ShopifyDomainNotFound] Could not determine current shop domain

but after upgrading shopify_app to (18.0.3), I am still getting the same error on activate charge and frame reload in the browser

Any help regarding this will be appreciated

[kirillplatonov]

@mjesar you need to pass host and shop params to return_url when creating a subscription. Example:

def url_with_params(url, params)
  uri = URI(url)
  uri.query = params.compact.to_query
  uri.to_s
end

callback_url = url_with_params(subscription_callback_url, {
  shop: current_shop.shopify_domain,
  host: current_shop.host
})

recurring_application_charge = ShopifyAPI::RecurringApplicationCharge.create(
  name: "Plan Name",
  price: 100,
  return_url: callback_url,
)
fullpage_redirect_to recurring_application_charge.confirmation_url

[mjesar]

@mjesar you need to pass host and shop params to return_url when creating a subscription. Example:

def url_with_params(url, params)
  uri = URI(url)
  uri.query = params.compact.to_query
  uri.to_s
end

callback_url = url_with_params(subscription_callback_url, {
  shop: current_shop.shopify_domain,
  host: current_shop.host
})

recurring_application_charge = ShopifyAPI::RecurringApplicationCharge.create(
  name: "Plan Name",
  price: 100,
  return_url: callback_url,
)
fullpage_redirect_to recurring_application_charge.confirmation_url

Thank you! it works now
But fullpage_redirect_to didnt work for me so i used
render js: "window.top.location = '#{charge.confirmation_url}';"
this was in response to an ajax call