-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to App Bridge 2 #41
Comments
can you share what local changes you've made to the app? i've just tried bumping the |
Do you have this line of code in your theme: |
my branch uses the unversioned/latest unpkg link unchanged from the main branch: https://github.com/Shopify/turbolinks-jwt-sample-app/blob/shopify_app-18-update/app/views/layouts/embedded_app.html.erb#L27 which resolves to |
Should we continue to use
in shopify_app.js? It seems like that's working instead of |
Here's an example app with JWT integration and AppBridge 2: https://github.com/kirillplatonov/shopify-hotwire-sample |
@netwire88 -- sorry for the delay. |
@tdonia can we also merge App Bridge 2 related PR in shopify_app gem? And once it merge I could also open PR with this change: kirillplatonov/shopify_app@b46ccc1 |
This is a requirement now to pass the app review.
The text was updated successfully, but these errors were encountered: